Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text composer is removing carriage returns #2170

Closed
spongythecake opened this issue Jan 5, 2024 · 4 comments
Closed

Text composer is removing carriage returns #2170

spongythecake opened this issue Jan 5, 2024 · 4 comments
Labels
A-Rich-Text-Editor O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@spongythecake
Copy link

When composing a regular message, individuals often organize their conversations by creating paragraphs for new thoughts.

Video included

https://github.com/element-hq/element-x-android/assets/146408892/9cd16424-abea-44ef-bee9-cb71ce01d806
What I expect:

  1. Type the first sentence to match the length of the composer.
  2. Press the Carriage Return button.
  3. Start the next sentence on a new line.

What actually happens:

  1. Type the first sentence to match the length of the composer.
  2. Press the Carriage Return button.
  3. New lines are removed.
  4. The expanded box contracts.

It happens both on reply and non-reply msgs.

software info

  • Element X 0.4.0
  • Android 14
@jmartinesp jmartinesp added S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience A-Rich-Text-Editor labels Jan 5, 2024
@jmartinesp
Copy link
Member

I believe this should be fixed in matrix-org/matrix-rich-text-editor#916. Once we release a nightly with these changes I'll let you know so you can test it, if you want to.

@spongythecake
Copy link
Author

Great. I'd be willing to use nightly.

@manuroe
Copy link
Member

manuroe commented Mar 27, 2024

Tested on 0.4.8-nightly. It is fixed. Thanks @jmartinesp

@manuroe manuroe closed this as completed Mar 27, 2024
@spongythecake
Copy link
Author

Still experiencing this issue on 0.4.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rich-Text-Editor O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jmartinesp @manuroe @spongythecake