Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ElementCall] Pressing the lock button while a call is ongoing promply ends the call #3136

Closed
stefanceriu opened this issue Aug 8, 2024 · 2 comments
Closed

[ElementCall] Pressing the lock button while a call is ongoing promply ends the call #3136

stefanceriu opened this issue Aug 8, 2024 · 2 comments
Assignees
@stefanceriu
Labels
A-Call S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@stefanceriu
Copy link
Member

This happens no matter the location app, springboard or lockscreen.
@stefanceriu stefanceriu self-assigned this Aug 8, 2024
@stefanceriu stefanceriu added the S-Major Severely degrades major functionality or product features, with no satisfactory workaround label Aug 8, 2024
stefanceriu added a commit that referenced this issue Aug 8, 2024
@stefanceriu
Fixes #3136 - Stop manually configuring ElementCall's AudioSession
7722dad 
- CallKit decides what action to to take when pressing the hardware lock button based on where the audio is routed to. Using the speaker will make it lock the phone while using the headset will make it end the call.
- Before the introduction of CallKit we had to manually setup the AudioSession to keep the audio live in the background. This is now clashing with CallKit making it bevelie the audio is not routed to the speaker and causing the call be terminated when pressing the lock button.
@stefanceriu
Copy link
Member Author

  • CallKit decides what action to to take when pressing the hardware lock button based on where the audio is routed to. Using the speaker will make it lock the phone while using the headset will make it end the call.
  • Before the introduction of CallKit we had to manually setup the AudioSession to keep the audio live in the background. This is now clashing with CallKit making it bevelie the audio is not routed to the speaker and causing the call be terminated when pressing the lock button.

@fkwp
Copy link

fkwp commented Sep 27, 2024

#3338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanceriu stefanceriu

Labels
A-Call S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefanceriu @fkwp