Complete quoting for parameters of some CMake commands

[elfring]

Some parameters (like "${TEST_DIR}") are passed to CMake commands in your build script without enclosing them by quotation marks. I see that these places will result in build difficulties if the contents of the used variables will contain special characters like semicolons.

I would recommend to apply advices from a wiki article.

[poulson]

While elfring is clearly trolling large numbers of projects (see his public activity) and has been blocked from this project, this is perhaps a valid point if a user is building Elemental from a directory whose full path contains a special character.

[justusc]

The most common problem that I have seen arise from not quoting paths is from paths that contain spaces on OS X. It is treated as a list and generates two (or more) incorrect paths.

[poulson]

Great point. This should definitely be avoided through introducing quotes then. I'm a bit backed up with other changesets right now so it may take a while to get to this.

[jeffhammond]

I was burned by this quote issue within the past 48 hours (uwsampa/grappa#257) so it's definitely something to fix.

[poulson]

In that case, I'll increase its priority in my queue!

[rhl-]

Is this still open? it looks like there was a commit addressing it.