Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defaulting to multitouch physical clicking can be unwanted on touchpads with touchpad area indications #183

Open
2 of 3 tasks
zach-hopkins opened this issue Jul 3, 2020 · 8 comments

Comments

@zach-hopkins
Copy link

Prerequisites

  • I have searched open and closed issues for duplicates.

Describe the bug

Right click on a laptop trackpad basically never works out of the box. I have a small sample size (4 notebook/laptop computers - Lenovo, Clevo, x2 Dell), however, right clicking worked on zero of them until I changed the touchpad settings to "touchpad areas". Any thought of potentially making "Touchpad Areas" default?

If applicable, add screenshots or screen recordings to help explain your problem.

Expected behavior

Out of the box right click functionality on laptop trackpads

Platform Information

OS: Elementary

  • OS Version Hera

Please check what applies:
-->

  • I'm using the latest version from git that I've manually compiled
  • I'm using the latest released stable version
@danirabbit danirabbit transferred this issue from elementary/os Jul 10, 2020
@danirabbit
Copy link
Member

When using "Hardware default" does two-finger tap work as a right click?

@zach-hopkins
Copy link
Author

When using "Hardware default" does two-finger tap work as a right click?

Yes it does.

@danirabbit
Copy link
Member

I think that sounds like this is working as intended then. If your hardware default is two-finger tap and that’s working as described, I’m not sure this is a valid report except to say that you prefer something other than your hardware default which is why there is a setting :)

@cassidyjames any thoughts about this?

@zach-hopkins
Copy link
Author

zach-hopkins commented Jul 13, 2020

Laptop trackpads i've tested have distinct 'click' areas - intention is for hard right-click/left-click.

@cassidyjames
Copy link
Contributor

Hold on, I think two different things are being conflated. Taps and physical clicking are treated completely separately by LibInput, so one doesn't affect the other.

Two-finger tap (tapping on the surface without physically clicking down) for secondary click is always enabled as long as "Tap to click" is enabled, which it is out of the box in elementary OS. elementary OS also defaults to "Multitouch" physical clicking by design, i.e. using two fingers to click down on and depress a trackpad. I think we chose this default because otherwise it can be confusing why two-finger tapping works but two-finger clicking only works on certain hardware.

That said, I would not be super opposed to trying "Hardware default" physical clicking and seeing if folks generally find it does the right thing on their hardware. This is super hardware-dependent, though, and I believe that data lives in LibInput itself.

@cassidyjames
Copy link
Contributor

@zach-hopkins for clarity, does right-clicking work as you'd expect (phyiscally depressing the bottom-right area of the trackpad) when you choose "Hardware default" for physical clicking?

@zach-hopkins
Copy link
Author

zach-hopkins commented Aug 25, 2020 via email

@cassidyjames
Copy link
Contributor

@danrabbit so we could try out "Hardware default" here as a default, though I suspect it will be a change that some don't like; for example, on Pinebook Pro, the "hardware default" from LibInput is for touchpad areas, even though it has no indication of those areas on the trackpad. I believe the same thing was often the case for System76 and Dell hardware as well—maybe LibInput defaults to areas if there's no data?

@cassidyjames cassidyjames changed the title Laptop Right Click Defaults Don't Work Defaulting to multitouch physical clicking can be unwanted on touchpads with touchpad area indications Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants