Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship as native package #297

Open
leolost2605 opened this issue Jan 25, 2025 · 2 comments
Open

Ship as native package #297

leolost2605 opened this issue Jan 25, 2025 · 2 comments

Comments

@leolost2605
Copy link
Member

leolost2605 commented Jan 25, 2025

Just opening this up for discussion.
While flatpak is great for a lot of stuff I think it might not be the best fit for a built in screenshot tool.

  1. Most obvious: permission issues. While we don't have to deal with screenshot permissions yet since we only use the interactive portal we'll have to deal with them at a later point once some upstream changes are merged. The big issue here is that it might be unintuitive that the - once again: built in - screenshot app requests permission to take a screenshot. Another thing that might already pose problems is that while we're taking an interactive screenshot we require background permission which if accidentally disabled by the user (because why would a screenshot tool require background permission, it will just suck up my battery) will lead to the app just being killed.
  2. Speed: Usually not a problem but flatpaks do have a somewhat noticeable launch time. With normal apps you kinda expect that but with just a screenshot UI you usually expect it to show up immediately (or at least it's much nicer for a quick action like taking a screenshot)
  3. There aren't that many drawbacks:
    • the app won't be able to be uninstalled
    • we are limited to the dependency versions the base systems ships which for an app that doesn't require much should be manageable

Those are just my thoughts lmk what u think (especially the speed thing kinda annoys me even though it's not even a full second lol) :)

@danirabbit
Copy link
Member

Yeah I'm not super opposed to this. Once the notification branch lands in Gala it's not like this repo will have much more than a desktop file in it 😅

@danirabbit danirabbit added this to OS 9 Jan 25, 2025
@leolost2605
Copy link
Member Author

Yeah that's another thing. The more I've been thinking about it the more I grow attached to the idea of handling all screenshots and their keyboard shortcuts here. This way we could use a lot of existing infrastructure (e.g. GLib.Application.send_notification) and keep gala code slimmer.

That's just brainstorming from my side though and I think @lenemter might have some opinions :)

(FWIW not really arguing against the gala branches here since it's probably OS 9 material and the notification infrastructure in gala will have to be redone anyways sometime since with the recent flatpak updates we should start treating the org.freedesktop.Notifications server as deprecated in favor of the portal)

@lenemter lenemter moved this to Needs Discussion in OS 9 Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs Discussion
Development

No branches or pull requests

2 participants