Secondary click on tab header results in segfault

[djaeris]

What Happened?

Something is clearly wrong with secondary mouse clicks (right-click for right-handed people) and tab headers in the Terminal. Long click results in menu, short click crashes the whole thing. The window header works fine.

Steps to Reproduce

1. Open Terminal
2. Short click the tab header with the secondary button
3. Terminal is gone

Expected Behavior

Contextual menu should appear.

OS Version

8.x (Early Access)

Session Type

Secure Session (Wayland)

Software Version

Latest release (I have run all updates)

Log Output

okt 10 05:18:44 aerisbase systemd[1309]: Started vte-spawn-dbd93319-115e-49a2-8db8-5af6ec80ddd4.scope - VTE child process 13589 launched by io.elementary.terminal process 2494.
okt 10 05:18:44 aerisbase kernel: show_signal_msg: 90 callbacks suppressed
okt 10 05:18:44 aerisbase kernel: io.elementary.t[2494]: segfault at 64ba18db540b ip 00007c905969d495 sp 00007ffe35069f90 error 4 in libgdk-3.so.0.2409.32[7c9059679000+84000] likely on CPU 1 (core 1, socket 0)
okt 10 05:18:44 aerisbase kernel: Code: 00 00 00 00 00 f3 0f 1e fa 55 48 89 e5 53 48 89 fb 48 83 ec 08 e8 fb ac ff ff 48 85 db 74 46 48 89 c6 48 8b 03 48 85 c0 74 05 <48> 39 30 74 0c 48 89 df e8 5e 0e fe ff 85 c0 74 2a 0f b6 43 4c 3c
okt 10 05:18:44 aerisbase systemd[1]: Created slice system-systemd\x2dcoredump.slice - Slice /system/systemd-coredump.
okt 10 05:18:44 aerisbase systemd[1]: Started [email protected] - Process Core Dump (PID 13608/UID 0).
okt 10 05:18:45 aerisbase systemd-coredump[13609]: Process 2494 (io.elementary.t) of user 1000 dumped core.
                                                   
                                                   Module libzstd.so.1 from deb libzstd-1.5.5+dfsg2-2build1.1.amd64
                                                   Module libsystemd.so.0 from deb systemd-255.4-1ubuntu8.4.amd64
                                                   Stack trace of thread 2494:
                                                   #0  0x00007c905969d495 gdk_window_get_effective_parent (libgdk-3.so.0 + 0x4e495)
                                                   #1  0x00007c90596fc408 n/a (libgdk-3.so.0 + 0xad408)
                                                   #2  0x00007c90596cd65b n/a (libgdk-3.so.0 + 0x7e65b)
                                                   #3  0x00007c90596cd91d n/a (libgdk-3.so.0 + 0x7e91d)
                                                   #4  0x00007c90595dbb16 n/a (libffi.so.8 + 0x7b16)
                                                   #5  0x00007c90595d83ef n/a (libffi.so.8 + 0x43ef)
                                                   #6  0x00007c90595db0be ffi_call (libffi.so.8 + 0x70be)
                                                   #7  0x00007c90580f8bfe n/a (libwayland-client.so.0 + 0x6bfe)
                                                   #8  0x00007c90580f9473 n/a (libwayland-client.so.0 + 0x7473)
                                                   #9  0x00007c90580f971c wl_display_dispatch_queue_pending (libwayland-client.so.0 + 0x771c)
                                                   #10 0x00007c90596ba6b0 n/a (libgdk-3.so.0 + 0x6b6b0)
                                                   #11 0x00007c90596866eb gdk_display_get_event (libgdk-3.so.0 + 0x376eb)
                                                   #12 0x00007c90596c24be n/a (libgdk-3.so.0 + 0x734be)
                                                   #13 0x00007c90599da5b5 n/a (libglib-2.0.so.0 + 0x5d5b5)
                                                   #14 0x00007c9059a39717 n/a (libglib-2.0.so.0 + 0xbc717)
                                                   #15 0x00007c90599d9a53 g_main_context_iteration (libglib-2.0.so.0 + 0x5ca53)
                                                   #16 0x00007c905983188d g_application_run (libgio-2.0.so.0 + 0xe788d)
                                                   #17 0x000064bc52ae1a45 n/a (io.elementary.terminal + 0xda45)
                                                   #18 0x00007c905882a1ca n/a (libc.so.6 + 0x2a1ca)
                                                   #19 0x00007c905882a28b __libc_start_main (libc.so.6 + 0x2a28b)
                                                   #20 0x000064bc52ae1a95 n/a (io.elementary.terminal + 0xda95)
                                                   
                                                   Stack trace of thread 2498:
                                                   #0  0x00007c905891b4cd __poll (libc.so.6 + 0x11b4cd)
                                                   #1  0x00007c9059a3966e n/a (libglib-2.0.so.0 + 0xbc66e)
                                                   #2  0x00007c90599d9a53 g_main_context_iteration (libglib-2.0.so.0 + 0x5ca53)
                                                   #3  0x00007c90599d9aa9 n/a (libglib-2.0.so.0 + 0x5caa9)
                                                   #4  0x00007c9059a08c82 n/a (libglib-2.0.so.0 + 0x8bc82)
                                                   #5  0x00007c905889ca94 n/a (libc.so.6 + 0x9ca94)
                                                   #6  0x00007c9058929c3c n/a (libc.so.6 + 0x129c3c)
                                                   
                                                   Stack trace of thread 2501:
                                                   #0  0x00007c905891b4cd __poll (libc.so.6 + 0x11b4cd)
                                                   #1  0x00007c9059a3966e n/a (libglib-2.0.so.0 + 0xbc66e)
                                                   #2  0x00007c90599d9a53 g_main_context_iteration (libglib-2.0.so.0 + 0x5ca53)
                                                   #3  0x00007c9054f8e595 n/a (libdconfsettings.so + 0x7595)
                                                   #4  0x00007c9059a08c82 n/a (libglib-2.0.so.0 + 0x8bc82)
                                                   #5  0x00007c905889ca94 n/a (libc.so.6 + 0x9ca94)
                                                   #6  0x00007c9058929c3c n/a (libc.so.6 + 0x129c3c)
                                                   
                                                   Stack trace of thread 2497:
                                                   #0  0x00007c905892725d syscall (libc.so.6 + 0x12725d)
                                                   #1  0x00007c9059a3340d g_cond_wait (libglib-2.0.so.0 + 0xb640d)
                                                   #2  0x00007c90599a452b n/a (libglib-2.0.so.0 + 0x2752b)
                                                   #3  0x00007c9059a0c043 n/a (libglib-2.0.so.0 + 0x8f043)
                                                   #4  0x00007c9059a08c82 n/a (libglib-2.0.so.0 + 0x8bc82)
                                                   #5  0x00007c905889ca94 n/a (libc.so.6 + 0x9ca94)
                                                   #6  0x00007c9058929c3c n/a (libc.so.6 + 0x129c3c)
                                                   
                                                   Stack trace of thread 2502:
                                                   #0  0x00007c905892725d syscall (libc.so.6 + 0x12725d)
                                                   #1  0x00007c9059a3340d g_cond_wait (libglib-2.0.so.0 + 0xb640d)
                                                   #2  0x00007c90599a452b n/a (libglib-2.0.so.0 + 0x2752b)
                                                   #3  0x00007c90599a458c g_async_queue_pop (libglib-2.0.so.0 + 0x2758c)
                                                   #4  0x00007c90584d90fb n/a (libpangoft2-1.0.so.0 + 0xc0fb)
                                                   #5  0x00007c9059a08c82 n/a (libglib-2.0.so.0 + 0x8bc82)
                                                   #6  0x00007c905889ca94 n/a (libc.so.6 + 0x9ca94)
                                                   #7  0x00007c9058929c3c n/a (libc.so.6 + 0x129c3c)
                                                   
                                                   Stack trace of thread 2499:
                                                   #0  0x00007c905891b4cd __poll (libc.so.6 + 0x11b4cd)
                                                   #1  0x00007c9059a3966e n/a (libglib-2.0.so.0 + 0xbc66e)
                                                   #2  0x00007c90599daf77 g_main_loop_run (libglib-2.0.so.0 + 0x5df77)
                                                   #3  0x00007c9059864422 n/a (libgio-2.0.so.0 + 0x11a422)
                                                   #4  0x00007c9059a08c82 n/a (libglib-2.0.so.0 + 0x8bc82)
                                                   #5  0x00007c905889ca94 n/a (libc.so.6 + 0x9ca94)
                                                   #6  0x00007c9058929c3c n/a (libc.so.6 + 0x129c3c)
                                                   ELF object binary architecture: AMD x86-64
okt 10 05:18:45 aerisbase systemd[1]: [email protected]: Deactivated successfully.
okt 10 05:18:45 aerisbase systemd[1309]: vte-spawn-5367c91b-adfb-4931-8655-fb7945534159.scope: Consumed 34.993s CPU time.

Hardware Info

No response

[jeremypw]

I could not reproduce this, although I was running OS8 in a Gnome Boxes VM. However I did get an addition commandline warning. The crash appears to happen deep in libgdk/libwayland rather than (directly) in Terminal. Does the the crash occur using a classic session? Does it occur if you raise the context menu another way (e.g. with the Menu key)?

[jeremypw]

There is a Gtk4 version in the pipeline (#780 ) which hopefully will work better with Wayland.

[djaeris]

I wasn't able to reproduce it in the Classic session. In the Secure session it isn't completely reproducible. Sometimes you have to click several times, but if you persist, it will crash. The first time it happened to me, it was completely by accident (but it also took down with it a data sync with our cloud server that happened to run in a different tab — that was a scary moment).

[jeremypw]

OK, I'll try some more. Please note that OS8 Early Access is not suitable for production use. Please use a stable version for any important work.

[jeremypw]

I reproduced this briefly on a new OS8 VM but it seemed to disappear after updating everything. It did not happen with the Gtk4 branch. Looking at the relevant code it is likely to be an upstream issue - there are few moving parts within Terminal involved. Hdy.TabView handles creating and showing the menu - Terminal just provides a menumodel.