Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image deletion #1361

Open
Tracked by #163
nya-elimu opened this issue Jul 27, 2021 · 7 comments
Open
Tracked by #163

Add image deletion #1361

nya-elimu opened this issue Jul 27, 2021 · 7 comments
Assignees
Labels
ux/ui User Experience (UX) / User Interface (UI)

Comments

@nya-elimu
Copy link
Member

Finish the implementation of the code in the ImageDeleteController.

@nya-elimu nya-elimu changed the title Delete Image Add image deletion Aug 6, 2021
@nya-elimu nya-elimu added the ux/ui User Experience (UX) / User Interface (UI) label Aug 6, 2021
@tomaszsmy tomaszsmy self-assigned this Jul 18, 2022
@tomaszsmy
Copy link
Contributor

I think first we must add image import to DbContentImportHelper.

@nya-elimu
Copy link
Member Author

nya-elimu commented Jul 24, 2022

I think first we must add image import to DbContentImportHelper.

@tomaszsmy Another option would be to go http://localhost:8080/webapp/content/multimedia/image/list and press the + button (to manually upload an image file).

@tomaszsmy
Copy link
Contributor

I have question about Store contribution event, we can't delete image without delete all contribution event.
Should I delete all ImageContributionEvent and then delete image?

@nya-elimu
Copy link
Member Author

I have question about Store contribution event, we can't delete image without delete all contribution event. Should I delete all ImageContributionEvent and then delete image?

@tomaszsmy Good observation 🙂
Yes, that's correct; Before deleting an image, we need to first make sure to delete its corresponding contribution events. This way we prevent entities being left orphaned in the database.

@tomaszsmy
Copy link
Contributor

#1603

@nya-elimu
Copy link
Member Author

@tomaszsmy For testing image deletion, I recommend you first upload some of these .epub files: https://github.com/elimu-ai/webapp/tree/main/src/test/resources/ai/elimu/util/epub

That will save you some time when developing on localhost.

@nya-elimu
Copy link
Member Author

#1603

Instead of linking to the PR in the issue, I recommend you type "closes #1361" in the PR description. That way, the issue will be closed automatically once the PR gets merged.

https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ux/ui User Experience (UX) / User Interface (UI)
Projects
None yet
Development

No branches or pull requests

2 participants