From 0aee17de656f1d1c42d955f66e33b37dbbbe82f0 Mon Sep 17 00:00:00 2001
From: Kip Cole <kipcole9@gmail.com>
Date: Mon, 8 Jul 2024 08:25:44 +1000
Subject: [PATCH] Add tests for 'at' formats

---
 lib/cldr/backend/date_time.ex  | 14 +++++++-------
 lib/cldr/date_time.ex          | 12 ++++++------
 test/cldr_dates_times_test.exs | 27 +++++++++++++++++++++++++++
 3 files changed, 40 insertions(+), 13 deletions(-)

diff --git a/lib/cldr/backend/date_time.ex b/lib/cldr/backend/date_time.ex
index bd08776..c03e274 100644
--- a/lib/cldr/backend/date_time.ex
+++ b/lib/cldr/backend/date_time.ex
@@ -38,9 +38,9 @@ defmodule Cldr.DateAndTime.Backend do
           `:short`, `:medium`, `:long`, `:full`. If `:time_format` is not specified
           then the time format is defined by the `:format` option.
 
-        * `:style` is either `:at` or `:default`. When set to `:at` the datetime is
-          formatted with a localised string representing `<date> at <time>`. See
-          `Cldr.DateTime.Format.date_time_at_formats/2`.
+        * `:style` is either `:at` or `:default`. When set to `:at` the datetime may
+          be formatted with a localised string representing `<date> at <time>` if such
+          a format exists. See `Cldr.DateTime.Format.date_time_at_formats/2`.
 
         * `:prefer` is either `:unicode` (the default) or `:ascii`. A small number of
           formats have two variants - one using Unicode spaces (typically non-breaking space) and
@@ -124,9 +124,9 @@ defmodule Cldr.DateAndTime.Backend do
           `:short`, `:medium`, `:long`, `:full`. If `:time_format` is not specified
           then the time format is defined by the `:format` option.
 
-        * `:style` is either `:at` or `:default`. When set to `:at` the datetime is
-          formatted with a localised string representing `<date> at <time>`. See
-          `Cldr.DateTime.Format.date_time_at_formats/2`.
+        * `:style` is either `:at` or `:default`. When set to `:at` the datetime may
+          be formatted with a localised string representing `<date> at <time>` if such
+          a format exists. See `Cldr.DateTime.Format.date_time_at_formats/2`.
 
         * `:prefer` is either `:unicode` (the default) or `:ascii`. A small number of
           formats have two variants - one using Unicode spaces (typically non-breaking space) and
@@ -152,7 +152,7 @@ defmodule Cldr.DateAndTime.Backend do
 
         * `formatted_datetime` or
 
-        * raises an exception
+        * raises an exception.
 
         ## Examples
 
diff --git a/lib/cldr/date_time.ex b/lib/cldr/date_time.ex
index 150dc0e..320e66b 100644
--- a/lib/cldr/date_time.ex
+++ b/lib/cldr/date_time.ex
@@ -117,9 +117,9 @@ defmodule Cldr.DateTime do
     `:short`, `:medium`, `:long`, `:full`. If `:time_format` is not specified
     then the time format is defined by the `:format` option.
 
-  * `:style` is either `:at` or `:default`. When set to `:at` the datetime is
-    formatted with a localised string representing `<date> at <time>`. See
-    `Cldr.DateTime.Format.date_time_at_formats/2`.
+  * `:style` is either `:at` or `:default`. When set to `:at` the datetime may
+    be formatted with a localised string representing `<date> at <time>` if such
+    a format exists. See `Cldr.DateTime.Format.date_time_at_formats/2`.
 
   * `:prefer` is either `:unicode` (the default) or `:ascii`. A small number of
     formats have two variants - one using Unicode spaces (typically non-breaking space) and
@@ -252,9 +252,9 @@ defmodule Cldr.DateTime do
     any of the keys returned by `Cldr.DateTime.Format.date_time_formats/3`.
     The default is `:medium`.
 
-  * `:style` is either `:at` or `:default`. When set to `:at` the datetime is
-    formatted with a localised string representing `<date> at <time>`. See
-    `Cldr.DateTime.Format.date_time_at_formats/2`.
+  * `:style` is either `:at` or `:default`. When set to `:at` the datetime may
+    be formatted with a localised string representing `<date> at <time>` if such
+    a format exists. See `Cldr.DateTime.Format.date_time_at_formats/2`.
 
   * `:prefer` is either `:unicode` (the default) or `:ascii`. A small number of datetime
     formats have two variants - one using Unicode spaces (typically non-breaking space) and
diff --git a/test/cldr_dates_times_test.exs b/test/cldr_dates_times_test.exs
index 3d8da42..7ffc9cb 100644
--- a/test/cldr_dates_times_test.exs
+++ b/test/cldr_dates_times_test.exs
@@ -134,4 +134,31 @@ defmodule Cldr.DatesTimes.Test do
                ":date_format and :time_format cannot be specified if :format is also specified as a " <>
                  "format id or a format string. Found [time_format: :medium, date_format: :short]"}}
   end
+
+  test "Pluralized formats" do
+    datetime = ~U[2024-07-07 21:36:00.440105Z]
+
+    assert {:ok, "week 28 of 2024"} = Cldr.DateTime.to_string(~D[2024-07-08], format: :yw)
+    assert {:ok, "week 2 of July"} = Cldr.DateTime.to_string(~D[2024-07-08], format: :MMMMW)
+    assert {:ok, "8:11 AM"} = Cldr.DateTime.to_string(~T[08:11:02], format: :hm)
+    assert {:ok, "Sun 9:36 PM"} = Cldr.DateTime.to_string(datetime, format: :Ehm)
+  end
+
+  test "Unicode or ASCII preference" do
+    datetime = ~U[2024-07-07 21:36:00.440105Z]
+
+    unicode = Cldr.DateTime.to_string(datetime, format: :Ehm, prefer: :unicode)
+    ascii = Cldr.DateTime.to_string(datetime, format: :Ehm, prefer: :ascii)
+    assert unicode != ascii
+  end
+
+  test "'at' formats" do
+    datetime = ~U[2024-07-07 21:36:00.440105Z]
+
+    assert {:ok, "July 7, 2024 at 9:36:00 PM UTC"} =
+      Cldr.DateTime.to_string(datetime, format: :long, style: :at)
+
+    assert {:ok, "July 7, 2024, 9:36:00 PM UTC"} =
+      Cldr.DateTime.to_string(datetime, format: :long, style: :default)
+  end
 end