Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Matching Credit Card Logos #102

Closed
Node815 opened this issue Feb 2, 2024 · 3 comments · Fixed by #173
Closed

[Feature Request] Matching Credit Card Logos #102

Node815 opened this issue Feb 2, 2024 · 3 comments · Fixed by #173
Labels
enhancement New feature or request

Comments

@Node815
Copy link

Node815 commented Feb 2, 2024

For the Credit Card methods, we have two different ones we use in our household. Visa and Mastercard, To help differentiate which card a service is using, it would be ideal to have the Visa, Discover, and Amex logo:
https://www.merchantsignage.visa.com/brand_guidelines
https://www.discover.com/company/newsroom/media-downloads/

Amex Logo = American Express, I coulnd't find an official one from them, but it should be easy enough to find one in the wild on the web! I know this doesn't encompass all the payment methods, but these are pretty much the most common in the U.S. and worldwide as well.

Then upon selecting the payment method, the user can then select the card type used and it would reflect it accordingly.

@ellite
Copy link
Owner

ellite commented Feb 7, 2024

I actually had some CC types in the beginning, but then started finding more and more, and didn't want to go deeper on the rabbit hole. So I decided to just have "Credit Card".
If I have some time I might add some of them. But no promises.

@ellite ellite added the enhancement New feature or request label Feb 7, 2024
@jpbaril
Copy link
Contributor

jpbaril commented Feb 17, 2024

Instead of trying to bake into the tool every possible credit card, you could maybe make the credit card type having its own setting (kind of like the categories and currencies) where we could add ourselves the credit card brand and associated logo. Maybe more complex at first but then it's done once and for all and so allow for more flexibility.

EDIT: comes down to this other feature request: #60

@ellite
Copy link
Owner

ellite commented Mar 5, 2024

You can now add custom payment methods.
Regards.

@ellite ellite linked a pull request Mar 5, 2024 that will close this issue
@ellite ellite closed this as completed Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants