Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should SVG namespace property be "namespace" #3

Open
rupertlssmith opened this issue Apr 7, 2017 · 1 comment
Open

Should SVG namespace property be "namespace" #3

rupertlssmith opened this issue Apr 7, 2017 · 1 comment

Comments

@rupertlssmith
Copy link
Contributor

The SVG namespace is defined as:

svgNamespace : Attribute msg
svgNamespace =
VirtualDom.property "namespace" (Json.string "http://www.w3.org/2000/svg")

Should the "namespace" property actually be "xmlns"? As described here:

https://developer.mozilla.org/en/docs/Web/SVG/Namespaces_Crash_Course

@canadaduane
Copy link
Contributor

Interesting! I don't know where the original namespace property comes from. That's copied from the elm-lang/svg package. I'm surprised that it would be wrong. I agree though that based on the spec (and if I understand the intent of svgNamespace) it seems like xmlns is preferred. It's also strange to me that each node is using the svgNamespace attribute... that seems unnecessary (since namespaces, once declared, are used as the default for all inner scope elements).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants