Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display number of skipped tests #161

Open
ad-si opened this issue Feb 6, 2021 · 3 comments
Open

Display number of skipped tests #161

ad-si opened this issue Feb 6, 2021 · 3 comments

Comments

@ad-si
Copy link

ad-si commented Feb 6, 2021

Currently it does not say how many tests were skipped:

Running 148 tests. To reproduce these results, run: elm-test --fuzz 100 --seed 132114825190419

TEST RUN INCOMPLETE because Test.skip was used

Duration: 388 ms
Passed:   148
Failed:   0
@ad-si
Copy link
Author

ad-si commented Feb 6, 2021

Oh, I guess this is the wrong repository. Also opened the issue in the test runner repo: rtfeldman/node-test-runner#492
Feel free to close it here…

@mpizenberg
Copy link
Contributor

This behavior is due to the output of the fromTest function in elm-explorations/test. It would require a change there to also pass the result of countAllRunnables distribution.skipped to the Skipping custom type variant. So this is actually an issue relevent both for node-test-runner and this repo.

@harrysarson harrysarson reopened this Feb 9, 2021
@harrysarson
Copy link
Collaborator

The fix is probably to change the Skipping constructor here to be:

 type SeededRunners
     = Plain (List Runner)
     | Only (List Runner)
-    | Skipping (List Runner)
+    | Skipping { skipped: Int, tests: (List Runner) }
     | Invalid String

and then follow the compiler errors. I think a PR is welcome although this would be a major change so won't be released until elm-explorations/test 2.0.0 ships which would be a while into the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants