Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch SetCurrentText to be called in an anonymous function #5

Open
raorao opened this issue Oct 17, 2016 · 5 comments
Open

switch SetCurrentText to be called in an anonymous function #5

raorao opened this issue Oct 17, 2016 · 5 comments

Comments

@raorao
Copy link
Member

raorao commented Oct 17, 2016

the current code is confusing if you don't understand that SetCurrentText is itself a function.

@avh4
Copy link
Member

avh4 commented Oct 21, 2016

You mean change Html.Events.onInput Update.SetCurrentText to Html.Events.onInput (\text -> Update.SetCurrentText text) ?

@raorao
Copy link
Member Author

raorao commented Oct 21, 2016

yup!

@raorao
Copy link
Member Author

raorao commented Oct 25, 2016

Yup!
On Thu, Oct 20, 2016 at 9:22 PM Ɛərɪn VonderHaar [email protected]
wrote:

You mean change Html.Events.onInput Update.SetCurrentText to Html.Events.onInput
(\text -> Update.SetCurrentText text) ?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#5 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AASEtFlWgD2CPxp6AdbnUUeFc1ztMWKpks5q2D4fgaJpZM4KZFQo
.

@Fedreg
Copy link

Fedreg commented Oct 26, 2016

This was a great tutorial and it was very well explained except one spot. Adding the renderKey function in the Choose Your Own Emoji section confused me . You didn't mention much about it and it might be easier to understand if you add a quick hint about reusing some of the previously entered markup to create the function.

Maybe it was just me but I had to look at the source code to figure out what you were after.

@raorao
Copy link
Member Author

raorao commented Nov 1, 2016

thanks for the comment, @Fedreg! please open up a new issue for the renderKey problem -- and perhaps even make a PR to fix it! Contributions are definitely welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants