Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

creating a project with "-" in it breaks the build #34

Closed
isaacabraham opened this issue Sep 28, 2017 · 6 comments
Closed

creating a project with "-" in it breaks the build #34

isaacabraham opened this issue Sep 28, 2017 · 6 comments

Comments

@isaacabraham
Copy link
Contributor

I created a project called elmish-101. This fails, I think when you run the yarn step - fails to compile. It seems to replace the - with a _ in the path to the project.

Sorry - don't have the error with me any more but it's easy to repro.

@MangelMaxime
Copy link
Member

This is related to #7 and it is caused by dotnet template engine.

The solution is to manually fix webpack.config.js or do not use - and . in your project name...

@isaacabraham
Copy link
Contributor Author

Understood. Perhaps some warning somewhere / somehow? or in the docs?

@MangelMaxime
Copy link
Member

@isaacabraham Would it make sense to add it to the README ? With some warnings sign ?

One question, what was your reference to learn how to use the template ? The readme ? A blog post ?
This is just to determine, where we should place it.

@isaacabraham
Copy link
Contributor Author

I just followed the readme, yeah. IMHO that's the best place to put it as it's directly coupled with the code in the repo itself with some warnings, yes. The error is kind of hard to see - you get a load of red and unless you read the details careful it's easy to miss. In the worse case, this gives Fable a bad reputation because "it doesn't work" when it's not that at all.

@MangelMaxime
Copy link
Member

Ok thanks for the answer.

I added a warning in the README acffd3d

@alfonsogarciacaro
Copy link
Contributor

I heard once that it can be fixed by using a - and/or . in the project name placeholder, but I haven't tried, I'll try to check for the next release of the simple template. If it works maybe we can just remove the placeholder from the main file module name, as F# doesn't accept hyphens there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants