Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Allow configuration of php code lens file pattern #103

Open
BladeMF opened this issue Jan 18, 2024 · 3 comments
Open

Feature request: Allow configuration of php code lens file pattern #103

BladeMF opened this issue Jan 18, 2024 · 3 comments

Comments

@BladeMF
Copy link
Contributor

BladeMF commented Jan 18, 2024

It will be useful to be able to configure where code lens is enabled in php files. Not all folders with tests start with the text test. They may end with tests as well or have some other naming rule.

I can PR this.

@elonmallin
Copy link
Owner

Hi, my understanding is that phpunit naming convention requires test methods to start with test* or that the test attribute in a comment is used to be identified as a test.

If that's the case then I dont think we should add custom naming rules that arent officially supported in phpunit.

I found this in the docs here https://docs.phpunit.de/en/10.5/writing-tests-for-phpunit.html

@BladeMF
Copy link
Contributor Author

BladeMF commented Jan 19, 2024

You are correct, but the filter I am talking about is the directory filter, not the method filter. Code lens is not activated unless the directory name starts with test, which should be configurable.

@elonmallin
Copy link
Owner

Ah I see, please make a PR if you want :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants