websocket errors are not propagated to client

[fusionfoxy]

What version of Elysia is running?

1.2.10

What platform is your computer?

Linux 6.1.0-23-amd64 x86_64 unknown

What steps can reproduce the bug?

import { treaty } from "@elysiajs/eden";
import { describe, expect, test } from "bun:test";
import { Elysia } from "elysia";

const app = new Elysia()
.get("/", () => "Hello Elysia")
.ws('/ws', {
  beforeHandle(ws: any) {
    return ws.error(403, 'forbidden')
  }
})
.listen(4000);

describe("Elysia ws error test", () => {
  test("Elysia ws error", async () => {
    const api = treaty<typeof app>("localhost:4000");

    const ws = api.ws.subscribe();

    const p = new Promise<number>((res, rej) => {
      ws.on('open', () => {
        console.log("OPEN")
        rej();
      });
      ws.on('close', (event) => {
        console.error("CLOSE: ", event.code)
        rej();
      });
      ws.on('error', (event) => {
        console.log("EVENT: ", event)
        res(42);
      })
    })
    return expect(p).resolves.toBe(42);
  });
});

What is the expected behavior?

When the server websocket beforeHandle() returns ws.error(403, 'forbidden') I would expect the client websocket on error to be called with the 403 forbidden error.

What do you see instead?

Instead of the on error callback, the on close callback is called and the websocket status code is 1002 with no trace of the 403 code

$ bun test 
bun test v1.1.29 (6d43b366)

src/app.test.ts:
CLOSE:  1002
10 |   }
11 | })
12 | .listen(4000);
13 | 
14 | describe("Elysia ws error test", () => {
15 |   test("Elysia ws error", async () => {
                               ^
error: 

Expected promise that resolves
Received promise that rejected: Promise { <rejected> }

      at /home/tfk/Documents/elysiaTest/app/src/app.test.ts:15:27
✗ Elysia ws error test > Elysia ws error [4.88ms]

 0 pass
 1 fail
 1 expect() calls
Ran 1 tests across 1 files. [47.00ms]

Additional information

No response

Have you try removing the node_modules and bun.lockb and try again yet?

yes

[hisamafahri]

The problem I believe is in your test.

• p expected to resolve to 42
• beforeHandle method is interuppting the websocket handshake, hence it will close the connection (meaning we should listen to the close event in this case)
• But, your ws.on("close"), instead of resolve, use reject
• The test case fail

You can fix it by use res instead of rej.

describe("Elysia ws error test", () => {
  test("Elysia ws error", async () => {
    const api = treaty<typeof app>("localhost:4000");

    const ws = api.ws.subscribe();

    const p = new Promise<number>((res, rej) => {
      ws.on("open", () => {
        console.log("OPEN");
        rej();
      });
      ws.on("close", (event) => {
        console.error("CLOSE: ", event.code);
        res(42); //
      });
      ws.on("error", (event) => {
        console.log("EVENT: ", event);
        res(42);
      });
    });

    expect(p).resolves.toBe(42);
  });
});

That test suite should return the following:

bun test v1.2.0 (b0c5a765)

src/index.test.ts:
CLOSE:  1002
✓ Elysia ws error test > Elysia ws error [6.18ms]

 1 pass
 0 fail
 1 expect() calls
Ran 1 tests across 1 files. [16.00ms]

---

Yes, by that logic, if you expect rejects, and use rej, the test case will pass.