Nested t.Integer() validation too loose

[and-rose]

What version of Elysia is running?

1.2.10

What platform is your computer?

Darwin 24.1.0 arm64 arm

What steps can reproduce the bug?

wrote some tests for test/validator/body.test.ts to investigate t.Integer() validation that was passing through in my project. Found that it wasn't validating my integers at all and was only really checking there were numbers.

	it('rejects malformed integer from array object', async () => {
		const app = new Elysia().post('/', ({ body }) => body, {
			body: t.Array(
				t.Object({
					name: t.String(),
					job: t.String(),
					trait: t.Optional(t.String()),
					age: t.Integer(),
					rank: t.Integer()
				})
			)
		})
		const res = await app.handle(
			post('/', [
				{
					name: 'sucrose',
					job: 'alchemist',
					age: 16.4,
					rank: 4
				}
			])
		)

		expect(res.status).toBe(422)
	})

	it('rejects malformed integer directly in array', async () => {
		const app = new Elysia().post('/', ({ body }) => body, {
			body: t.Array(t.Integer())
		})
		const res = await app.handle(post('/', [1, 2, 3, 4.2]))

		expect(res.status).toBe(422)
	})

found that they fail and pass through a 200. Seems like integer support is new #953 and this may have been an oversight?

What is the expected behavior?

Elysia should validate the nested integer and return a 422

What do you see instead?

Elysia passes through the non-integer to deeper layers, unvalidated.

Additional information

No response

Have you try removing the node_modules and bun.lockb and try again yet?

yes

[nxht]

I think it's due to using t.Number() as union in the pull request mentioned.

https://github.com/elysiajs/elysia/pull/953/files#r1893933305
It should be fixed by changing the union type to Type.Integer as the comment said.

[Vadym-Balan]

I've passed error function inside t.Number() and it works.

  duration: t.Number({
    minimum: 1,
    maximum: 5,
    error() {
      return "Duration should be between 1 and 5";
    },
  }),

https://elysiajs.com/essential/validation.html#error-is-called-per-field