Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smerge-mode bindings not being activated #818

Open
Stewmath opened this issue Jun 3, 2024 · 1 comment
Open

Smerge-mode bindings not being activated #818

Stewmath opened this issue Jun 3, 2024 · 1 comment

Comments

@Stewmath
Copy link

Stewmath commented Jun 3, 2024

Smerge-mode bindings were added several years ago but were never added to evil-collection--supported-modes, so they never get loaded. Is there a reason for this?
cobac added a commit to cobac/system that referenced this issue Sep 1, 2024
@cobac
add smerge to evil-collection-init
c6c7a5b 
not working, adding the mode (as smerge or smerge-mode) to
evil-collection--supported-modes doesn't work...

- github.com/emacs-evil/evil-collection/issues/818
@cobac
Copy link

cobac commented Sep 10, 2024 •
edited
Loading

I tried just adding smerge (and smerge-mode) to evil-collection--supported-modes, but I couldn't get it to activate properly. I've hit the ceiling of my elisp debugging skills trying to get this to work.

(I can reproduce the issue using the clean init.el from the readme)

It'd be nice if someone more knowledgeable can have a look 😌

In the meantime (add-hook 'smerge-mode-hook 'evil-collection-smerge-mode-setup)) works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Stewmath @cobac