-
-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LSP-ESLint should support eslint.config.js-files #4341
Comments
Is there any current workaround for using eslint.config.js and have lsp-mode work for eslint backend? |
As of today vscode-eslint is in version 2.4.4, this repository (lsp-mode) is using version 2.2.2 , it could be that an upgrade here solves the issue. I can't upgrade it directly cause it's pulling from a compiled version from a non-official binary repo. I tried to hack an upgrade but spacemacs wouldn't recognize it. |
Were you able to find some sort of workaround? |
This is fixed by #4489 As a workaround until that is merged, you can use the eslint server from your local VSCode: (use-package lsp-eslint
:demand t
:after lsp-mode
:config
(setq lsp-eslint-server-command `("node"
"~/.vscode/extensions/dbaeumer.vscode-eslint-3.0.10/server/out/eslintServer.js"
"--stdio"))) This requires VSCode with Eslint extension installed locally Another option is to change the download URL for the server (setq lsp-eslint-download-url "https://marketplace.visualstudio.com/_apis/public/gallery/publishers/dbaeumer/vsextensions/vscode-eslint/3.0.10/vspackage") ;; latest VSCode eslint extension from marketplace Then |
The newer versions of ESLint read configurations from
eslint.config.js
-files and many new JavaScript/TypeScript-projects already define their configurations this way. This file should be added to the files lsp-mode searches for configuration when initializing the client!More about this here: https://eslint.org/docs/latest/use/configure/configuration-files-new
Note that the disclaimer is outdated and nowadays you can just use the file without specifying any of the flags on the disclaimer. The flat-config is on by default!
Apart from this there will be coming support for
eslint.config.cjs
andeslint.config.mjs
on the next major release for ESLint:eslint/eslint#17909
The text was updated successfully, but these errors were encountered: