Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete Installation Instructions/README #10

Open
liar666 opened this issue Sep 14, 2021 · 6 comments
Open

Incomplete Installation Instructions/README #10

liar666 opened this issue Sep 14, 2021 · 6 comments

Comments

@liar666
Copy link

liar666 commented Sep 14, 2021

Hi,

I've tried to install lsp-sonarlint. I'm particularly interested in its Java & JavaScript components.

Following the README in this repo, I did:

  • Install lsp-sonarlint in Emacs packages from MELPA
  • Complete my Emacs config file with
(require 'lsp-sonarlint)
(require 'lsp-sonarlint-javascript)
(setq lsp-sonarlint-javascript-enabled t)
(require 'lsp-sonarlint-java)
(setq lsp-sonarlint-java-enabled t)

But I get an error when starting Emacs:
File is missing: Cannot open load file, No such file or directory, lsp-sonarlint-javascript

You might have forgotten to give some steps in the install procedure in the README...

Could you please complete the README/docs so that a newbie like me can install a fully working Emacs + sonarlint setup?

Thanks

@Sasanidas
Copy link
Collaborator

Sorry about the response delay.

I reinstall the extension with the default settings, and seems like it work as intended, maybe you decline when lsp-sonarlint ask to download the extension? The behaviour is that if it doesn't found the extension, it will download it for you.

@MarcoHassan
Copy link

Hi all,

I also have troubles to keep up and running with this cool lsp integration.

I downloaded all the relevant package and set the relevant variables after requiring the module

   (use-package lsp-sonarlint
     :ensure t)

   (require 'lsp-sonarlint-java)
   (setq lsp-sonarlint-java-enabled t)

The sonarlint server seems to work and I do not get any errors. I can see a server at localhost:64474. I checked at the variables defined in the lsp-sonarlint-java module and they are correctly set.

Still when I try on purpose to introduce some non-compliant code as per here I do not get any sonarlint warnings.

Any suggestions? I suggest to write a 101 with a tutorial with example as per lsp-java or similar.

Best,
Marco

@ppena-LiveData
Copy link

Same for me. When I ran M-x lsp, I saw messages like the below that showed no errors or warnings, so I assume lsp-sonarlint installed what it needed, but I'm not seeing any SonarLint warnings from known problem code:

Contacting host: binaries.sonarsource.com:443
Wrote c:/Users/ppena/AppData/Roaming/.emacs.d/elpa/lsp-sonarlint-20220510.1802/languages/sonar-python.jar
LSP :: Connected to [pylsp:51512 c:/git/my-test-proj].

Is there some way to check if lsp-sonarlint is properly configured? I see *lsp-mode* and *pylsp* buffers in Emacs; should there also be a messages buffer for lsp-sonarlint?

@Sasanidas
Copy link
Collaborator

Thanks for the feedback, It's true that the server seems lo work as intended but for some reason is not triggering any code-action or warning.

This maybe because of the new version of the lsp server of sonarlint that may require some adjustment or this repository integration with lsp-mode that need to be fixed/updated.

In any case, I'm kind of lost, so ping @yyoncho , maybe he can give you more details.

@necto
Copy link
Contributor

necto commented Aug 13, 2023

I have upgraded SonarLint and its plugins to the latest versions used in the VSCode plugin in this PR. The CI tests suggest that it works pretty reliably. Please give it a go.

@necto
Copy link
Contributor

necto commented Jul 12, 2024

#22 has improved the on-boarding experience. Is this issue still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants