Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing this breaks splattributes for Glimmer components in Ember 3.8 #119

Open
mansona opened this issue Apr 21, 2020 · 0 comments
Open

Comments

@mansona
Copy link

mansona commented Apr 21, 2020

I know the title sounds a bit specific 🙈 but this is something that I came across when trying to upgrade the Ember Styleguide without dropping support for Ember 3.8.

I was passing splattributes down into one of our components but for some reason they weren't being applied (good thing there was a test to cover them)

I managed to identify it was this addon that was creating the issue and we removed the dependency for now (and sacrificed being able to use nested angle bracket syntax for the styleguide)

I made a quick recreation showing that just by adding this addon it breaks a test: mansona/attributes-glimmer-reproduction#1

let me know if you have any questions 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant