Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible issue with the template-only-glimmer-components optional-feature #22

Open
lennyburdette opened this issue Jul 10, 2018 · 2 comments

Comments

@lennyburdette
Copy link
Contributor

lennyburdette commented Jul 10, 2018

I couldn't reproduce this in an isolated test case. I have an application with "template-only-glimmer-components": true and ember-angle-bracket-invocation-polyfill 1.1.5 installed. (Ember and Ember CLI are all at the latest version.)

If I invoke a component using angle brackets like:

<FlashMessage class="some-class" data-foo="bar" />

I don't see the class or data- attribute added to the DOM element.

If I disable template-only-glimmer-components, it works as expected.

These components have JS classes (they're coming from an addon) so it's not due to actually using a template-only component. I just had a few simple components in the host app where I wanted outer-HTML semantics and no extra files.

@rwjblue
Copy link
Member

rwjblue commented Jul 11, 2018

Thanks for reporting! What Ember version were you using?

@lennyburdette
Copy link
Contributor Author

Ember 3.2 — I’m on the latest everything (it’s a new app). I even tried deleting my lockfile to make sure there wasn’t a transitive dependency that needed updating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants