Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

currentURL is empty in the browser when the APP is served by FastBoot #2

Open
MartinMalinda opened this issue Jul 1, 2017 · 2 comments

Comments

@MartinMalinda
Copy link

Experienced here: https://github.com/ember-learn/ember-api-docs/pull/239/files#diff-8be18fa18c3ed63d667abc0d4ae71015R34

When I serve the app with FastBoot disabled, currentURL works fine in the browser.
With FB enabled, currentURL is returned correctly in FB side but not in the browser.

@rwjblue
Copy link
Member

rwjblue commented Jul 1, 2017

Yikes, that's a weird one. How can I reproduce to debug?

@MartinMalinda
Copy link
Author

I tried to create a reproduction repository but I've kind of failed 🤦‍♂️
https://github.com/MartinMalinda/fastboot-current-url
Here the router service consistently returns null in all route lifecycle hooks. Maybe thats WAI and the currentURL should not be available sooner?

In the api-docs-repo it probably partially works because of some asynchronous promise resolving, but I should probably find a more reliable way to get the current URL anyways.

Maybe this can be closed:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants