Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON5 vulnerability in v7.x of ember-cli-babel #512

Open
LucasHillDex opened this issue Apr 12, 2024 · 3 comments
Open

JSON5 vulnerability in v7.x of ember-cli-babel #512

LucasHillDex opened this issue Apr 12, 2024 · 3 comments

Comments

@LucasHillDex
Copy link

LucasHillDex commented Apr 12, 2024

ember-cli-babel version 7.x is still widely used in the ember community, over 65% of downloads from npm are still on 7.x. There is a vulnerability in JSON5 being brought in from a transitive dependency of this package, that has been updated in ember-cli-babel 8.x. However it is impossible to remove version 7.x from ember projects given ember-source itself still depends on 7.x, along with many other ember community packages. I am hoping a patch version of ember 7.x could be released to remove this vulnerability.

This proposed PR should allow projects to get JSON5 0.5.1 out of their lockfiles #511

See vulnerability: https://security.snyk.io/vuln/SNYK-JS-JSON5-3182856

The dependency chain bringing in 0.5.1:

    └─┬ ember-cli-babel 7.26.11
      └─┬ babel-plugin-module-resolver 3.2.0
        └─┬ find-babel-config 1.2.0
          └── json5 0.5.1

Screenshot 2024-04-12 at 2 37 34 PM

@LucasHillDex
Copy link
Author

@chancancode are you primarily maintaining this repository? Just curious on your thoughts.

@LucasHill
Copy link

@chancancode I had to remake the PR under a different user, thanks. #513

@LucasHill
Copy link

find-babel-config got updated so this is no longer an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants