Skip to content
This repository has been archived by the owner on May 26, 2019. It is now read-only.

Tell user to (and how to) remove ember-welcome-page addon #2164

Open
Gaurav0 opened this issue Jan 5, 2018 · 5 comments
Open

Tell user to (and how to) remove ember-welcome-page addon #2164

Gaurav0 opened this issue Jan 5, 2018 · 5 comments

Comments

@Gaurav0
Copy link
Contributor

Gaurav0 commented Jan 5, 2018

https://guides.emberjs.com/v2.18.0/tutorial/ember-cli/#toc_the-development-server

talks about removing the welcome page component. We should to tell the user to (and how to) remove the ember-welcome-page addon as well.

@locks
Copy link
Contributor

locks commented Jan 7, 2018

@Gaurav0 the welcome page itself contains instructions how to do it, is that not enough?

@locks
Copy link
Contributor

locks commented Jan 7, 2018

We also instruct people on how to remove the component from the template. The addon will be inert if the component is not used, so you're not getting things you don't need in the build.

@dopin
Copy link
Contributor

dopin commented Jan 7, 2018

I want it be written too. For translation purpose.
Or should the welcome addon be i18n-ed?

@Gaurav0
Copy link
Contributor Author

Gaurav0 commented Jan 8, 2018

@locks
Copy link
Contributor

locks commented Jan 8, 2018

Ah, we updated the message when we made the addon not include its assets for production builds.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants