Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors found in the basic_datatypes notebook #232

Open
4 tasks done
Tracked by #243
despadam opened this issue May 6, 2024 · 6 comments · May be fixed by #256
Open
4 tasks done
Tracked by #243

Errors found in the basic_datatypes notebook #232

despadam opened this issue May 6, 2024 · 6 comments · May be fixed by #256
Assignees
Labels
bug Something isn't working

Comments

@despadam
Copy link
Collaborator

despadam commented May 6, 2024

  • Add import math in solution_circle_area() in basic_datatypes and explain that pi is defined there
  • It is not clear that quadratic equation expects two results
  • solution_number_is_lower_than_0_or_greater_than_100 in the test we check for >=
  • in comparison operators, explain the difference of == and isequal with the float number problem and how is it repsresented in bits
@despadam despadam added bug Something isn't working clarification Something to expand or make clearer and removed bug Something isn't working labels May 6, 2024
@despadam despadam changed the title Add import math Basic datatypes May 6, 2024
@despadam despadam added enhancement New feature or request and removed clarification Something to expand or make clearer labels May 6, 2024
@yakutovicha
Copy link
Member

in the def solution_number_is_even(number: float) -> bool: the input types do not match. It should be number:int

@baffelli
Copy link
Member

baffelli commented May 6, 2024

@baffelli
Copy link
Member

baffelli commented May 6, 2024

In the exercise solution_return_first_and_last_element_from_list, the annotated return type is list[float] however the solution checks for a tuple[float, float]. We should make this consistent

@baffelli
Copy link
Member

baffelli commented May 6, 2024

popitem does not remove an arbitrary element but the last element inserted into a dict.

@yakutovicha
Copy link
Member

For the record: it takes roughly 3 hours to finish the basic datatypes section, so we might want to give students a bit more time for the next tutorial.

@despadam despadam changed the title Basic datatypes Errors found in the basic_datatypes notebook May 6, 2024
@despadam despadam added bug Something isn't working and removed enhancement New feature or request labels May 8, 2024
@despadam
Copy link
Collaborator Author

despadam commented May 8, 2024

From #233: In the basic datatypes notebook, trying to convert a complex number to float raises a TypeError as expected. However, it doesn't print the error to the console unless it is surrounded by a try...except statement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants