Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor is_endorsed #291

Open
brenzi opened this issue Nov 26, 2022 · 0 comments
Open

refactor is_endorsed #291

brenzi opened this issue Nov 26, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@brenzi
Copy link
Member

brenzi commented Nov 26, 2022 •
edited
Loading

pallets/ceremonies/src/lib.rs

Lines 1883 to 1886 in 6f5adcd

fn is_endorsed(
participant: &T::AccountId,
cc: &CommunityCeremony,
) -> Option<CeremonyIndexType> {

a function named is_* usually returns bool

I suggest to rename this to get_most_recent_endorsement
@brenzi brenzi added the enhancement New feature or request label Nov 26, 2022
@brenzi brenzi changed the title rename is_endorsed refactor is_endorsed Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brenzi