Expo 49 - Breaking Changes

[hazirmagron]

Describe the bug
The overlay is completely broken since I updated to Expo@49.

The 'HoldItem' child components still animate when pressed. The overlay and menu never show up, however, and the child component that was pressed is frozen on the screen.

Package versions

• React: "18.2.0"
• React Native: "0.72.3"
• React Native Reanimated: "~3.3.0"
• React Native Hold Menu: "^0.1.6"
• Expo: "^49.0.0"

[holma91]

Is this fixed yet?

[pavelbabenko]

Same issue

[raymond-tetteh]

I have the same issue.

[mimo-10]

got the same issue her, any solutions suggested?

[Nasseratic]

Hello guys 👋🏼

I am working on a fix here 🤓 #112

It's WIP, but I got everything working on my project

[moedeveloper]

Unfortunately same issue :(

[devmalcolm]

Hey, is there a fixed version ? I saw the new PR being WIP and changes seems to works perfecly. Did you already publish it ? Or still WIP ? Thanks ✌️

[Nasseratic]

Hey @devmalcolm

Yeah, it should be ready. But I can't publish it as I am not a contributor. Will try to bring someone to approve my PR. For now feel free to install the version in the PR by:

npm i https://github.com/Nasseratic/react-native-hold-menu-upgrade-expo-49.git#expo-49-needed-fixes

[viktor32]

@Nasseratic great job, thank you!

But I think the correct command to install from your repo is (with the branch where the fix)

npm i https://github.com/Nasseratic/react-native-hold-menu-upgrade-expo-49.git#expo-49-needed-fixes

[BennoCrafter]

Hey @Nasseratic! I've downloaded your updated version, but sadly it still doesnt work. Is it just me, or is it because there is a new version?

[MathiasSvDK]

Same issue. Using expo 50

[mimo-10]

It works, you only need to use this version
npm i https://github.com/Nasseratic/react-native-hold-menu-upgrade-expo-49.git#expo-49-needed-fixes
And you need to make a change inside the backdrop component in order to make it work on android.
Just change View, to AnimatedBlurView

[BennoCrafter]

Just for android?

[mimo-10]

Yes, you need to do that only for android, for ios it works without any changes.

[tconroy]

Im having trouble trying to install this fork.. 🤔 any ideas?

❯ npm i https://github.com/Nasseratic/react-native-hold-menu-upgrade-expo-49.git#expo-49-needed-fixes
zsh: no matches found: https://github.com/Nasseratic/react-native-hold-menu-upgrade-expo-49.git#expo-49-needed-fixes

[Nasseratic]

@tconroy It works for me 😅

[tconroy]

@tconroy It works for me 😅

Yes I just needed to wrap the url as a string and now it works 😊

[daxaxelrod]

Can we merge the upgrade to 49 (also confirming nasseratic's fix works on expo 50) to main

[BraeschAntoine]

Thx your solution worked perfectly, your fork saved my day ! I don't understand why this isn't already merged