Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is project still maintained ? #97

Closed
n0mer opened this issue Apr 4, 2023 · 5 comments
Closed

Is project still maintained ? #97

n0mer opened this issue Apr 4, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@n0mer
Copy link

n0mer commented Apr 4, 2023

Hi @enesozturk , congratulations with your new job and Center Pixel and relocation to USA.

What do you think of transfering this repo to one of fork authors?

Project is still used, but forks can help only with one-time temp fixes that ultimately should land in main repository:

image

@athombv @SohelIslamImran what do you think, is there oss maintainer with good reputation to take over or a least merge PRs with fixes and keep dependencies (expo. haptics etc) up-to-date ? Expo has 6 month compatibility window, so this should be done on a regular basis.

@n0mer n0mer added the bug Something isn't working label Apr 4, 2023
@SohelIslamImran
Copy link

That would be great.

@n0mer
Copy link
Author

n0mer commented Apr 4, 2023

Can you publish your fork under different npm coordinates , post link there - so people can add pull requests from their fork to that new repo ? Until @enesozturk is back, we would have consolidated version with fixes. For example , fork of @athombv (which is most fresh) is missing zIndex fix that is present in other fork .

@enesozturk
Copy link
Owner

Hey @n0mer. Thank you for considering the state of this package. I don't think about moving this package to another author. It's been a while since I couldn't take care of the issues & PRs, and I am still not pretty sure that this production-ready package is. Running this animation on low-end devices might lead to a bad user experience. I am open to PRs that improve the user experience especially low-end & Android devices.

Let me check out the recent PRs and merge them if they are ok. Thanks, have a great day.

@n0mer
Copy link
Author

n0mer commented Apr 6, 2023

@enesozturk can you please re-consider #76 and corresponding contribution from #77 by @SohelIslamImran SohelIslamImran

@kesha-antonov
Copy link
Contributor

Hey @n0mer. Thank you for considering the state of this package. I don't think about moving this package to another author. It's been a while since I couldn't take care of the issues & PRs, and I am still not pretty sure that this production-ready package is. Running this animation on low-end devices might lead to a bad user experience. I am open to PRs that improve the user experience especially low-end & Android devices.

Let me check out the recent PRs and merge them if they are ok. Thanks, have a great day.

Hi
We use it in production for a while and it works good
rn-reanimated and rn-gesture-handler libs on which this package is based proved that they're fast and stable
So it would be great to see this package have maintenance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants