diff --git a/.travis.yml b/.travis.yml index 8eca3e61f78..672f32708d3 100644 --- a/.travis.yml +++ b/.travis.yml @@ -3,5 +3,4 @@ rvm: before_script: - "export DISPLAY=:99.0" - "sh -e /etc/init.d/xvfb start" - - "npm install -g jshint" -script: "rake test[all] && rake jshint" +script: "rake test[all]" diff --git a/Assetfile b/Assetfile index 4105e9b661d..91c8d7d0fbf 100644 --- a/Assetfile +++ b/Assetfile @@ -23,6 +23,16 @@ class EmberLicenseFilter < Rake::Pipeline::Filter end end +class JSHintRC < Rake::Pipeline::Filter + def generate_output(inputs, output) + inputs.each do |input| + file = File.read(input.fullpath) + jshintrc = File.read(".jshintrc") + output.write "var JSHINTRC = #{jshintrc};\n\n#{file}" + end + end +end + distros = { :runtime => %w(ember-metal ember-runtime), :full => %w(handlebars ember-metal ember-runtime ember-views ember-states metamorph ember-handlebars) @@ -44,6 +54,10 @@ input "packages" do concat "ember-tests.js" end + + match "ember-tests.js" do + filter JSHintRC + end end input "packages" do diff --git a/Rakefile b/Rakefile index 46db1a11c9d..0351a74561b 100644 --- a/Rakefile +++ b/Rakefile @@ -288,21 +288,6 @@ namespace :docs do end end -desc "Run jshint" -task :jshint do - unless system("which jshint > /dev/null 2>&1") - abort "Please install jshint. `npm install -g jshint`" - end - - if system("jshint packages/ember*") - puts "The JavaScript is clean".green - else - puts "The JavaScript is dirty".red - exit(1) - end -end - - desc "Run tests with phantomjs" task :test, [:suite] => :dist do |t, args| unless system("which phantomjs > /dev/null 2>&1") @@ -311,7 +296,11 @@ task :test, [:suite] => :dist do |t, args| suites = { :default => ["package=all"], - :all => ["package=all", "package=all&jquery=1.6.4", "package=all&extendprototypes=true", "package=all&extendprototypes=true&jquery=1.6.4"] + :all => ["package=all", + "package=all&jquery=1.6.4&nojshint=true", + "package=all&extendprototypes=true&nojshint=true", + "package=all&extendprototypes=true&jquery=1.6.4&nojshint=true", + "package=all&dist=build"] } suite = args[:suite] || :default diff --git a/tests/index.html b/tests/index.html index f278956c484..07bbfa81a83 100644 --- a/tests/index.html +++ b/tests/index.html @@ -5,6 +5,39 @@