Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAProxy health check does not support multiple vhosts #209

Open
sfnelson opened this issue Feb 24, 2021 · 1 comment
Open

HAProxy health check does not support multiple vhosts #209

sfnelson opened this issue Feb 24, 2021 · 1 comment

Comments

@sfnelson
Copy link

https://github.com/engineyard/ey-cookbooks-stable-v6/blob/next-release/cookbooks/haproxy/recipes/configure.rb#L45

haproxy_httpchk_host = app.vhosts.first.domain_name.empty? ? nil : app.vhosts.first.domain_name

This line configures HAProxy to use the domain name configured in the app's vhost, but the documentation for Domain Name states:

Enter comma-separated values. Wildcards and regular expressions are allowed.

In practice, this value is a list of space-separated strings intended for the nginx server_name directive, which can include regexes.

I'm not sure how the HAProxy recipe should deal with regex values, but at least it should check for _ and handle multiple values appropriately.

@dvalfre
Copy link
Contributor

dvalfre commented May 15, 2022

This issue has (finally!) been prioritized and the fix will be part of the next release, aimed at happening during the current month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants