Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Ears mod #24

Open
notLily72 opened this issue Aug 9, 2022 · 9 comments
Open

Compatibility with Ears mod #24

notLily72 opened this issue Aug 9, 2022 · 9 comments

Comments

@notLily72
Copy link

The mod: https://modrinth.com/mod/ears

When you turn off the chestplate armor piece with the ears mod installed, the chest setting of ears does not stop rendering. I have talked to unascribed, inorder for the rendering of the chest armor to be disabled the ears api should be used to tell ears whether to stop rendering the extra bit of armor.

https://github.com/unascribed/Ears#using-the-api

How it currently looks:
image

How it should look
image

@notLily72 notLily72 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 9, 2022
@notLily72 notLily72 reopened this Aug 9, 2022
@enjarai
Copy link
Owner

enjarai commented Aug 9, 2022

I don't mind adding compat for this, but how would that work with transparency? The API does not seem to have support for that.

@notLily72
Copy link
Author

notLily72 commented Aug 9, 2022

yeah it appears that the api doesn't support it. Would it be possible to have it disable the armor piece completely once transparency is set to 0%?

@enjarai
Copy link
Owner

enjarai commented Aug 14, 2022

I'm trying to replicate this, but can't figure out how to make the chest show up using the ears mod. It's not an option on the skin configurator page, and I can't find any other documentation.

@notLily72
Copy link
Author

It is currently a hidden option, if you would like I could upload my skin file with it?

@enjarai
Copy link
Owner

enjarai commented Aug 14, 2022

That'd work yes.

@notLily72
Copy link
Author

f

@chitinlink
Copy link

It's been a bit, is this looking like it'll be possible?

@enjarai
Copy link
Owner

enjarai commented Sep 5, 2022

I've been looking into it, but the ears codebase is extremely complex due to it being available for almost every minecraft version out there.

When I'm implementing compat, I want it to support transparency as well. That usually requires a mixin into the other mod, which for most mods isn't a big problem. But due to the complexity of ears, I haven't been able to find the right place to inject my own stuff.

Currently, I don't have the free time to browse and comprehend all that code to find the specific spot where I need to change something, so I'll have to put this on hold until I do.

If you really want this compat, you could try contacting the dev of ears about implementing transparency support into the api.

@enjarai
Copy link
Owner

enjarai commented Sep 5, 2022

Actually, I contacted the dev myself just now, and they plan to add support for transparency to the api. Once that's available, I'll add compat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants