-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with Ears mod #24
Comments
I don't mind adding compat for this, but how would that work with transparency? The API does not seem to have support for that. |
yeah it appears that the api doesn't support it. Would it be possible to have it disable the armor piece completely once transparency is set to 0%? |
I'm trying to replicate this, but can't figure out how to make the chest show up using the ears mod. It's not an option on the skin configurator page, and I can't find any other documentation. |
It is currently a hidden option, if you would like I could upload my skin file with it? |
That'd work yes. |
It's been a bit, is this looking like it'll be possible? |
I've been looking into it, but the ears codebase is extremely complex due to it being available for almost every minecraft version out there. When I'm implementing compat, I want it to support transparency as well. That usually requires a mixin into the other mod, which for most mods isn't a big problem. But due to the complexity of ears, I haven't been able to find the right place to inject my own stuff. Currently, I don't have the free time to browse and comprehend all that code to find the specific spot where I need to change something, so I'll have to put this on hold until I do. If you really want this compat, you could try contacting the dev of ears about implementing transparency support into the api. |
Actually, I contacted the dev myself just now, and they plan to add support for transparency to the api. Once that's available, I'll add compat. |
The mod: https://modrinth.com/mod/ears
When you turn off the chestplate armor piece with the ears mod installed, the chest setting of ears does not stop rendering. I have talked to unascribed, inorder for the rendering of the chest armor to be disabled the ears api should be used to tell ears whether to stop rendering the extra bit of armor.
https://github.com/unascribed/Ears#using-the-api
How it currently looks:
![image](https://user-images.githubusercontent.com/86197720/183543687-b5c3c88c-0629-4845-b2a5-d401bc1da8da.png)
How it should look
![image](https://user-images.githubusercontent.com/86197720/183543711-274e7702-90eb-4014-82d6-8c3788652514.png)
The text was updated successfully, but these errors were encountered: