Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running a command (rather than a .desktop file) from j4dd breaks zplug. #91

Open
setpill opened this issue Jul 11, 2019 · 2 comments
Open
Labels
dmenu-issue dmenu problems/bugs/limitations and other external stuff (e.g. shell escaping)

Comments

@setpill
Copy link

setpill commented Jul 11, 2019

$ j4-dmenu-desktop --dmenu='echo echo' --term='asdfasdfasdf'
Read 62 .desktop files, found 48 apps.
User input is: echo 
/bin/zsh -i -c 'echo'
[zplug] WARNING: pipe syntax is deprecated! Please use 'on' tag instead.
[zplug] WARNING: pipe syntax is deprecated! Please use 'on' tag instead.
[zplug] WARNING: pipe syntax is deprecated! Please use 'on' tag instead.
[zplug] WARNING: pipe syntax is deprecated! Please use 'on' tag instead.
[zplug] WARNING: pipe syntax is deprecated! Please use 'on' tag instead.
[zplug] WARNING: pipe syntax is deprecated! Please use 'on' tag instead.
[zplug] WARNING: pipe syntax is deprecated! Please use 'on' tag instead.
[zplug] WARNING: pipe syntax is deprecated! Please use 'on' tag instead.
[zplug] WARNING: pipe syntax is deprecated! Please use 'on' tag instead.
[zplug] WARNING: pipe syntax is deprecated! Please use 'on' tag instead.
[zplug] WARNING: pipe syntax is deprecated! Please use 'on' tag instead.
[zplug] WARNING: pipe syntax is deprecated! Please use 'on' tag instead.
[zplug] WARNING: pipe syntax is deprecated! Please use 'on' tag instead.
[zplug] WARNING: pipe syntax is deprecated! Please use 'on' tag instead.
[zplug] WARNING: pipe syntax is deprecated! Please use 'on' tag instead.
[zplug] WARNING: pipe syntax is deprecated! Please use 'on' tag instead.
[zplug] WARNING: pipe syntax is deprecated! Please use 'on' tag instead.
[zplug] WARNING: pipe syntax is deprecated! Please use 'on' tag instead.
[zplug] WARNING: pipe syntax is deprecated! Please use 'on' tag instead.
[zplug] WARNING: pipe syntax is deprecated! Please use 'on' tag instead.
Removed '/home/[USER]/.zplug/repos/[SOME REPO DIR]' 
Removed '/home/[USER]/.zplug/repos/[SOME REPO DIR]' 
Removed '/home/[USER]/.zplug/repos/[SOME REPO DIR]' 
Removed '/home/[USER]/.zplug/repos/[SOME REPO DIR]' 
Removed '/home/[USER]/.zplug/repos/[SOME REPO DIR]' 
Removed '/home/[USER]/.zplug/repos/[SOME REPO DIR]' 
Removed '/home/[USER]/.zplug/repos/[SOME REPO DIR]' 
Removed '/home/[USER]/.zplug/repos/[SOME REPO DIR]' 
Removed '/home/[USER]/.zplug/repos/[SOME REPO DIR]' 
Removed '/home/[USER]/.zplug/repos/[SOME REPO DIR]' 
Removed '/home/[USER]/.zplug/repos/[SOME REPO DIR]' 
Removed '/home/[USER]/.zplug/repos/[SOME REPO DIR]' 
Removed '/home/[USER]/.zplug/repos/[SOME REPO DIR]' 
Removed '/home/[USER]/.zplug/repos/[SOME REPO DIR]' 
Removed '/home/[USER]/.zplug/repos/[SOME REPO DIR]' 
Removed '/home/[USER]/.zplug/repos/[SOME REPO DIR]' 
Removed '/home/[USER]/.zplug/repos/[SOME REPO DIR]' 

(NB: username and repo dirs details obfuscated because did not seem relevant. If they might be, please let me know and I can post a list).

@setpill
Copy link
Author

setpill commented Jul 13, 2019

I stripped all the plugins from my config and reduced my .zshrc to just install zplug and self-manage it as a plugin.

.zshrc:

# Check if zplug is installed
if [[ ! -d ${HOME}/.zplug ]]; then
	git clone https://github.com/zplug/zplug ${HOME}/.zplug
	source ${HOME}/.zplug/init.zsh && zplug update
else
	source ${HOME}/.zplug/init.zsh
fi

# Self-manage
zplug "zplug/zplug", hook-build:"zplug --self-manage"

zplug check || zplug install
zplug clean --force

# Then, source plugins and add commands to $PATH
zplug load

Repeating the j4dd test above results in:

$ j4-dmenu-desktop --dmenu='echo echo' --term='asdfasdfasdf'
Read 62 .desktop files, found 48 apps.
User input is: echo 
/bin/zsh -i -c 'echo'
[zplug] WARNING: pipe syntax is deprecated! Please use 'on' tag instead.
Removed '[$HOME]/.zplug/repos/zplug/zplug' 
__zplug::core::core::run_interfaces:14: __check__: function definition file not found
__zplug::core::core::run_interfaces:14: __load__: function definition file not found
$

This confirms that it is not the fault of some plugin I am using.

@enkore enkore added the dmenu-issue dmenu problems/bugs/limitations and other external stuff (e.g. shell escaping) label Sep 12, 2020
@enkore
Copy link
Owner

enkore commented Sep 12, 2020

j4dd pretty much just does "exec $SHELL", so if something breaks there, it's usually some kind of configuration issue. I'd raise this with zplug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dmenu-issue dmenu problems/bugs/limitations and other external stuff (e.g. shell escaping)
Projects
None yet
Development

No branches or pull requests

2 participants