-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document Existence of Web UI #41
Comments
Related to this, the enochecker/src/enochecker/checkerservice.py Line 129 in 724f1ff
|
Why and how? Stringify can't know what you want to do? |
In that case the Web UI maybe shouldn't display the spec in the input field by default, but instead in addition to same valid example JSON. Personally I found it more confusing to have those optional fields with default values that lead to the JSON object being invalid when they could have just as well been filled with the default values. |
What should the default value for the address be? |
While you can't put in a default value for the address (although localhost and the port specified in the checker class might be a good guess), the rest of the defaults should be set such that specifying the address and method should be enough for most use cases. |
Address and method is enough for all use cases, the checkerlib sets sane defaults for all other values, if I recall correctly. |
See the spec:
Only the first two are marked Required .This should probably also be documented. (This makes it pretty easy to use via httpie on the commandline as well) |
I think @MMunier has been doing some work on the Web UI recently |
With the new web UI, would you consider this issue to be resolved? I would say the new interface is pretty self-explanatory |
Well some keys like the "UniqueVariantId" could use some onhover-texts, but I belive it is in a sufficient state to consider it done. |
It looks like this issue is more about "how do I spawn and access the checker web UI". |
is it? |
That was Lucas' "related to this" sidetrack. |
I guess this is a subset of the newer #54 though, so closing |
The most convenient way to test checkerlib is via the webui, however this feature is not well-documented in the readme.
The text was updated successfully, but these errors were encountered: