diff --git a/src/vptstools/bin/vph5_to_vpts.py b/src/vptstools/bin/vph5_to_vpts.py index cbb3fd6..9b0ac08 100644 --- a/src/vptstools/bin/vph5_to_vpts.py +++ b/src/vptstools/bin/vph5_to_vpts.py @@ -116,7 +116,7 @@ def cli(modified_days_ago): h5_path = OdimFilePath.from_s3fs_enlisting(file_key) h5_local_path = str(temp_folder_path / h5_path.file_name) # inbo_s3.get_file(file_key, h5_local_path) - # s3f3 failes in wrapped moto environment; fall back to boto3 + # s3f3 fails in wrapped moto environment; fall back to boto3 s3_client.download_file( S3_BUCKET, f"{h5_path.s3_folder_path_h5}/{h5_path.file_name}", diff --git a/tests/test_vph5_to_vpts.py b/tests/test_vph5_to_vpts.py index 57cc191..0bb219c 100644 --- a/tests/test_vph5_to_vpts.py +++ b/tests/test_vph5_to_vpts.py @@ -84,5 +84,6 @@ def test_e2e_cli_all(s3_inventory, path_inventory, tmp_path, sns): assert "Create 5 daily vpts files" in result.output assert "Recreate the full set of bucket files" in result.output # test fails/stops after creation of first daily file (only files provided for test) - assert result.exception is not None + assert "[WARNING] - During conversion" in result.output + assert result.exception is None # TODO - check if notification is sent to the SNS-TOPIC (currently only sent to mocked endpoint)