Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode theme code readability #11

Open
joenash opened this issue May 20, 2020 · 4 comments
Open

Dark mode theme code readability #11

joenash opened this issue May 20, 2020 · 4 comments
Labels
Category: Dark Theme The documentation's dark theme Change: Non-Breaking A change that will not break links to the site Difficulty: Core Contributor Should only be attempted by a core contributor Priority: Medium Should be completed in the next few sprints Type: Enhancement An enhancement to the docs site

Comments

@joenash
Copy link
Contributor

joenash commented May 20, 2020

General Summary

Code blocks in the dark mode theme aren't super readable. Needs brighter colours.
@joenash joenash added Category: Dark Theme The documentation's dark theme Change: Non-Breaking A change that will not break links to the site Difficulty: Core Contributor Should only be attempted by a core contributor Priority: Medium Should be completed in the next few sprints Type: Enhancement An enhancement to the docs site labels May 20, 2020
@iamrecursion
Copy link
Contributor

This page is a good example of how unreadable it can be.

@joenash
Copy link
Contributor Author

joenash commented May 20, 2020 •
edited by unfurl-links bot
Loading

Aiming for Solarized for colour schemes: https://github.com/thomasf/solarized-css

GitHub
Contribute to thomasf/solarized-css development by creating an account on GitHub.

@iamrecursion
Copy link
Contributor

To clarify, this should just be for the syntax highlighting, not the whole page!

@joenash
Copy link
Contributor Author

joenash commented May 20, 2020

Thanks! That's what I thought, but appreciated all the same 😁

@joenash joenash mentioned this issue Jul 7, 2020
Merged
2 tasks
npentrel pushed a commit to npentrel/enso-org.github.io that referenced this issue Oct 30, 2020
@kustosz
Project manager (enso-org#11)
c2a60eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Dark Theme The documentation's dark theme Change: Non-Breaking A change that will not break links to the site Difficulty: Core Contributor Should only be attempted by a core contributor Priority: Medium Should be completed in the next few sprints Type: Enhancement An enhancement to the docs site
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joenash @iamrecursion