From e37d5858f9d50b33481259772cd49075b4a9620c Mon Sep 17 00:00:00 2001 From: Adi Suissa-Peleg Date: Fri, 7 Feb 2025 16:57:59 +0000 Subject: [PATCH] minor-perf: move secret provide string Signed-off-by: Adi Suissa-Peleg --- source/common/secret/secret_provider_impl.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/source/common/secret/secret_provider_impl.cc b/source/common/secret/secret_provider_impl.cc index 5ec21455ef31..4c83962e1924 100644 --- a/source/common/secret/secret_provider_impl.cc +++ b/source/common/secret/secret_provider_impl.cc @@ -56,7 +56,7 @@ ThreadLocalGenericSecretProvider::ThreadLocalGenericSecretProvider( if (const auto* secret = provider_->secret(); secret != nullptr) { auto value_or_error = Config::DataSource::read(secret->secret(), true, api_); SET_AND_RETURN_IF_NOT_OK(value_or_error.status(), creation_status); - value = *value_or_error; + value = std::move(value_or_error.value()); } tls_->set([value = std::move(value)](Event::Dispatcher&) { return std::make_shared(value); @@ -71,7 +71,7 @@ absl::Status ThreadLocalGenericSecretProvider::update() { if (const auto* secret = provider_->secret(); secret != nullptr) { auto value_or_error = Config::DataSource::read(secret->secret(), true, api_); RETURN_IF_NOT_OK_REF(value_or_error.status()); - value = *value_or_error; + value = std::move(value_or_error.value()); } tls_->runOnAllThreads( [value = std::move(value)](OptRef tls) { tls->value_ = value; });