Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send ACS parameters for layout and convert backend functions #5365

Closed
AlexanderSavelyev opened this issue Aug 27, 2024 · 2 comments · Fixed by #5549 · May be fixed by #5601
Closed

Send ACS parameters for layout and convert backend functions #5365

AlexanderSavelyev opened this issue Aug 27, 2024 · 2 comments · Fixed by #5549 · May be fixed by #5601
Assignees
@AnnaKosol
Labels
ACS standard Team G
Milestone
Ketcher 2.26.0-rc.1

Comments

@AlexanderSavelyev
Copy link
Contributor

AlexanderSavelyev commented Aug 27, 2024 •
edited by accmeboot
Loading

Background
Related issue: #5152, epam/Indigo#2176

Solution
the following parameters should be sent when requesting layout and convert backend functions :

bond-length-unit
bond-length
reaction-component-margin-size-unit
reaction-component-margin-size
image-resolution
accmeboot pushed a commit that referenced this issue Aug 27, 2024
#5365 -- added new fileds to indigo requests
616f739
@accmeboot accmeboot self-assigned this Aug 27, 2024
@accmeboot accmeboot linked a pull request Aug 27, 2024 that will close this issue
#5365 - Send ACS parameters for layout and convert backend functions #5369
Closed
9 tasks
@AlexeyGirin
Copy link
Collaborator

ACS-StyleGuide.pdf

accmeboot pushed a commit that referenced this issue Sep 4, 2024
#5365 -- updated with bond spacing changes
853bda6
accmeboot pushed a commit that referenced this issue Sep 4, 2024
#5365 -- conflict fix
cf74b16
accmeboot pushed a commit that referenced this issue Sep 5, 2024
#5365 -- added server options on paste layout event
adb100d
@accmeboot accmeboot linked a pull request Sep 27, 2024 that will close this issue
#5362 - Sending ACS parameters when requesting render to PNG and SVG #5601
Open
9 tasks
@rrodionov91 rrodionov91 linked a pull request Oct 3, 2024 that will close this issue
#5351 - Change the default size of a plus and the arrows #5549
Merged
9 tasks
@AnnaKosol
Copy link
Contributor

Image

Image

Verified

Environment
https://rc.test.lifescience.opensource.epam.com/KetcherDemoSA/index.html
Ketcher Version 2.26.0-rc.1 Build at 2024-10-04; 18:45:04
Indigo Version 1.25.0-rc.1.0-g704673fcb-wasm32-wasm-clang-19.0.0
MacOs
Chrome 129.0.6668.71 (Official Build) (arm64)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnnaKosol AnnaKosol

Labels
ACS standard Team G
Projects
None yet
Milestone
Ketcher 2.26.0-rc.1
5 participants
@AlexanderSavelyev @accmeboot @AlexeyGirin @AnnaKosol @AlekseiKhariukov