Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noisier failures with ssh-group #137

Open
tomconnors opened this issue Oct 6, 2021 · 4 comments
Open

Noisier failures with ssh-group #137

tomconnors opened this issue Oct 6, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@tomconnors
Copy link
Contributor

The docs indicate that if one server in ssh-group has a failure, the others will continue. I think that should be configurable (I'd like the whole thing to crash in that case), but it should at least log a warning. The following code just logs "I'm on the server" then :ok

(ns test
  (:require
   [spire.modules :as spire]
   [clojure.string :as string]))

(defn main []
  (spire/ssh-group
   [{:hostname "10.10.3.250" :username "ubuntu"}]
   (spire/debug "I'm on the server")
   (spire/debug (string/trim nil))
   (spire/debug "All done"))
  :ok)

(main)
@retrogradeorbit
Copy link
Member

This could be done. The confusing issue is that one host may be much further along the script than the failing host. Or much earlier. The hosts don't run in lockstep. They each run as fast as they can. Is that an issue for what you are doing? Is it just about error readability?

@retrogradeorbit retrogradeorbit added the enhancement New feature or request label Feb 24, 2022
@tomconnors
Copy link
Contributor Author

This is just about readability; I had a failing script and didn't realize it.

@retrogradeorbit
Copy link
Member

What do you think of collating those errors and reporting them at the end of execution?

@tomconnors
Copy link
Contributor Author

That would work for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants