Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve discretise #776

Open
seabbs opened this issue Sep 17, 2024 · 4 comments
Open

Improve discretise #776

seabbs opened this issue Sep 17, 2024 · 4 comments
Assignees

Comments

@seabbs
Copy link
Contributor

seabbs commented Sep 17, 2024

primarycensoreddist now supports numerically solved double censored pmf calculation (https://primarycensoreddist.epinowcast.org/dev/articles/primarycensoreddist.html#compute-the-primary-event-censored-probability-mass-function-pmf-with-dprimarycensoreddist) which we should replace our current approximate dicretise approach with either wrapped or directly.

@seabbs
Copy link
Contributor Author

seabbs commented Sep 19, 2024

@sbfnk as discussed f2f today

@kaitejohnson
Copy link
Contributor

kaitejohnson commented Sep 25, 2024

Will open a new issue re making more explicit how the indexing is handled (starting at t=1, as indicated in model definition) in the case when a user passes in a discrete pmf.

@seabbs
Copy link
Contributor Author

seabbs commented Dec 3, 2024

Does anyone want to take this on? I think it would be better if it wasn't me implementing given I am so in the weeds already on primarycensored.

@seabbs seabbs self-assigned this Feb 3, 2025
@seabbs
Copy link
Contributor Author

seabbs commented Feb 3, 2025

Happy to take this on at the same time as #350 and using a similar approach to epinowcast/epinowcast#549 (but using that code internally vs in a vignette/example).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants