Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce number of times long fitting code is run in tests #223

Closed
athowes opened this issue Aug 2, 2024 · 3 comments
Closed

Reduce number of times long fitting code is run in tests #223

athowes opened this issue Aug 2, 2024 · 3 comments
Labels
medium Nice to have for next release

Comments

@athowes
Copy link
Collaborator

athowes commented Aug 2, 2024 •
edited
Loading

Is there a way to reduce the number of times we are calling fit <- epidist() inside tests?
@athowes athowes added the medium Nice to have for next release label Aug 8, 2024
@seabbs seabbs added high Required for next release and removed medium Nice to have for next release labels Sep 20, 2024
@athowes
Copy link
Collaborator Author

athowes commented Nov 6, 2024

Maybe this can be solved with something like having stored fits.

This would also be useful for #157.

@seabbs seabbs added medium Nice to have for next release and removed high Required for next release labels Nov 13, 2024
@seabbs
Copy link
Contributor

seabbs commented Nov 13, 2024

I've dropped this down to medium

@athowes
Copy link
Collaborator Author

athowes commented Jan 30, 2025

I believe this was fixed by @seabbs at various PRs reducing the amount of long running tests.

@athowes athowes closed this as not planned Won't fix, can't repro, duplicate, stale Jan 30, 2025
@seabbs seabbs reopened this Jan 30, 2025
@seabbs seabbs closed this as completed Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
medium Nice to have for next release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seabbs @athowes