Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up installation #499

Closed
kgostic opened this issue Jan 15, 2025 · 10 comments
Closed

Speed up installation #499

kgostic opened this issue Jan 15, 2025 · 10 comments
Labels
high Required for next release

Comments

@kgostic
Copy link
Collaborator

kgostic commented Jan 15, 2025

The last time I tried to install the package, it took over an hour and never finished. Is it possible this is related to? #105?

@seabbs stated he had started working on this, but I'm not sure what's been done or how to close this out.

@kgostic kgostic added the high Required for next release label Jan 15, 2025
@athowes
Copy link
Collaborator

athowes commented Jan 20, 2025

I thought that #105 related to cloning into the repository but wouldn't relate to installation of the package, but I could be wrong.

@seabbs
Copy link
Contributor

seabbs commented Jan 20, 2025

yes this is related I think as I would imagine it was trying to clone the repo for a long time (which is the first step of github instal I think). Could be mistaken but will likely only be clear once #105 is resolved.

@seabbs
Copy link
Contributor

seabbs commented Jan 21, 2025

given the changes in #105 could anyone having install problems please give it another go and report back. I saw no issues and no change between now and previously so would be good to get some insight.

@seabbs
Copy link
Contributor

seabbs commented Jan 21, 2025

I just did a clean install (i.e. a fresh install of R) which took just under a minute. My expectation is that any remaining issues here are platform specific so as above feedback would be great.

@athowes
Copy link
Collaborator

athowes commented Jan 21, 2025

It's possible that @kgostic slow install time could have been installing dependencies (on the VAP).

@seabbs
Copy link
Contributor

seabbs commented Jan 21, 2025

Something to note when looking into this is I found two 100mb full fits in the inst folder. This is ultimately what was causing the issue with R universe and may have been causing the issue with remotes installation (due to fire wall rules for large file sizes and connection stability).

@seabbs
Copy link
Contributor

seabbs commented Jan 28, 2025

Circling back to this. My expectation is that install via remotes should now work. We can hold this open until binaries are being built on the Universe which should speed things up a few orders of magnitude (eta tomorrow).

@kgostic
Copy link
Collaborator Author

kgostic commented Jan 28, 2025

If you ping again here, I'll try to test this tomorrow.

@athowes
Copy link
Collaborator

athowes commented Jan 28, 2025

Installation via remotes::install_github works fine for me.

@seabbs
Copy link
Contributor

seabbs commented Feb 12, 2025

Closing this as assumed resolved

@seabbs seabbs closed this as completed Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high Required for next release
Projects
None yet
Development

No branches or pull requests

3 participants