Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caching support for transaction and event proofs #1981

Open
Mirko-von-Leipzig opened this issue Apr 30, 2024 · 0 comments
Open

Add caching support for transaction and event proofs #1981

Mirko-von-Leipzig opened this issue Apr 30, 2024 · 0 comments

Comments

@Mirko-von-Leipzig
Copy link
Contributor

Mirko-von-Leipzig commented Apr 30, 2024

This should be done last.

Add caching to the transaction and event proofs. We don't store the merkle trie for these during sync - we only calculate them once off to verify the commitment values match. These RPC methods will therefore be expensive since they re-calculate the commitments for each call.

Adding caching will greatly improve matters here. This cache should also include values from the sync as these are likely to be popular.

We probably want request coalescing since it is likely that proofs for the same block will occur multiple times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant