Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support encodings for all the components of chapter 3 #187

Closed
achaikou opened this issue Nov 25, 2019 · 2 comments
Closed

Support encodings for all the components of chapter 3 #187

achaikou opened this issue Nov 25, 2019 · 2 comments
Labels
postponed life is too short

Comments

@achaikou
Copy link
Contributor

Based on #183
Patch helps with correct encoding of string attribute values, but doesn't touch encoding errors.

Errors based on the patch:

  • Encoding error on loading due to fingerprint processing (no correct encoding provided) - set names and object names.
  • Could not allocate string object - template labels.
  • SIGABRT - on encoded obname as value. Depending on the source of the error, it might appear that more tests are required.

The only situation encountered in real world is a fingerprint error on reading object name. Set is private and looks like it has been used to send information for private purposes.

Situation with object units and set names is unclear, as we do not return them to the user, so don't know if they are affected.

Tests would be submitted soon.

@ErlendHaa
Copy link
Contributor

Point 1 should go away if fingerprint is byte string

@ErlendHaa ErlendHaa added the postponed life is too short label Jan 23, 2020
@ErlendHaa ErlendHaa removed the blocked label Oct 16, 2020
@ErlendHaa
Copy link
Contributor

The issues related to string encoding in fdata and obnames in general are solved, while the SIGABRT issues are described in more detail in #295, so I will close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
postponed life is too short
Projects
None yet
Development

No branches or pull requests

2 participants