Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider checking for reamaining data after every read in parse #210

Closed
achaikou opened this issue Dec 9, 2019 · 1 comment
Closed

Consider checking for reamaining data after every read in parse #210

achaikou opened this issue Dec 9, 2019 · 1 comment

Comments

@achaikou
Copy link
Contributor

achaikou commented Dec 9, 2019

parse.cpp: currently we verify if we have more data only after reading set, template and object.

It's unlikely that any of the actual files will fail because of this, as most of truncated data would fail in findoffsets. It however might happen in case of some new specification-break we haven't foreseen.
Tests test_parse/cut_middle..., do not fail now. More info in commit message 3bc16d.
@achaikou achaikou mentioned this issue Sep 17, 2020
Open
@ErlendHaa
Copy link
Contributor

A particular case of #295

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ErlendHaa @achaikou