Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ircevent: allow message truncation by default #59

Closed
slingamn opened this issue Apr 20, 2021 · 2 comments · Fixed by #60
Closed

ircevent: allow message truncation by default #59

slingamn opened this issue Apr 20, 2021 · 2 comments · Fixed by #60

Comments

@slingamn
Copy link
Member

After the dust settled with the truncation changes (#45, #48), we made LineBytesStrict return ErrorBodyTooLong if the message is truncated.

ircevent does not check for this error, so truncation causes outgoing messages to be dropped. This is probably not the behavior bot authors expect. We should add a config variable like DisallowTruncation (i.e., truncation is allowed by default), and then check it and check that error value.

@slingamn
Copy link
Member Author

We should also expose a normalizer: thoj/go-ircevent#127

@slingamn slingamn linked a pull request Apr 23, 2021 that will close this issue
@slingamn
Copy link
Member Author

I went with AllowTruncation (i.e., truncation disabled by default).

slingamn added a commit that referenced this issue Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant