Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests out of the shipped library #2

Open
ericoporto opened this issue Feb 15, 2021 · 1 comment
Open

Move tests out of the shipped library #2

ericoporto opened this issue Feb 15, 2021 · 1 comment

Comments

@ericoporto
Copy link
Owner

It's a bit too soon for the things in the public API but some internals could be tested.

I think I would just use my own tap module for that.

Right now, the code at least have some expect(bool expr) so at least it can do some sanity checks at runtime.

@ericoporto ericoporto changed the title Task: add tests Move tests out of the shipped library Feb 21, 2021
@ericoporto
Copy link
Owner Author

I actually added some minor tests, I obviously can add more, I need to move ImGi tests to a separate module.

I think it's possible to import the internals on other file and use it because AGS kinda don't care as long as things link fine at runtime.

I could even add an extra room and then rename it to room1.crm and use it to run the tests in the CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant