Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use generic python module #50

Open
floek opened this issue Feb 12, 2023 · 3 comments
Open

Use generic python module #50

floek opened this issue Feb 12, 2023 · 3 comments

Comments

@floek
Copy link

floek commented Feb 12, 2023

Hi @erikkastelec,

I want to push my wemportal sensor values to a influxdb for grafana dashboard visualization. As I'm not using Home Assistant, I needed a standalone python module to scrape data from wemportal. So, I created one thanks to your code examples.

It's here (very early state):
https://github.com/floek/wemportal

Maybe it's usefull for the community.

Best,
floek

@erikkastelec
Copy link
Owner

Hi,

Looks great. API part was really in need of refactoring, as it was barely readable, to be honest.
I will be replacing it will your module as soon as I test it out.

Thank you!

@floek
Copy link
Author

floek commented Feb 13, 2023

Write support is missing, and it could use some unit tests. But, its a starting point.Feel free to contribute ;)

@ghenzler
Copy link
Contributor

The downside of using a separate module is, that you cannot easily make little tweaks directly in home assistant because the referenced module is not available for edit directly in under https://homeassistant.local:8123/... I'd personally prefer a just a folder for wem-api and wem-portal with classes that don't have dependencies to HA and once checked out via git locally, you can run without home assistant. The root folder can then just have the glue code to map the return of wem-api / wem-portal to the HA world....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants