Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot change default configuration #174

Open
AlexanderLJX opened this issue Apr 17, 2023 · 4 comments
Open

Cannot change default configuration #174

AlexanderLJX opened this issue Apr 17, 2023 · 4 comments
Labels

Comments

@AlexanderLJX
Copy link

AlexanderLJX commented Apr 17, 2023

I tried changing the configurations but it doesn't seem to work. Using the search just searches with the default settings even after I have changed the settings and it just reverts back to the default when I check the settings again after performing a search.

For example, here I set the ThresholdDifference to 50 and perform a search but it still searches with the default ThresholdDifference of 5

image

I tried using the latest release and building from source but both don't work.
The previous v2.3.10 release is able work, but it doesn't have the "auto delete but Saati Index" function.

@heinrichI
Copy link
Collaborator

I confirm the bug, I'll see how the time will be.

@heinrichI
Copy link
Collaborator

@Edi61 Right now CoreCompareOptions is designed to store options and setting is done by calling the CoreLib property. I don't want this usage in AntiDupl.NET.WPF. I want to set the property in C++ immediately when setting the property in C#. Should I make a separate option model in AntiDupl.NET.WPF?

@Edi61
Copy link
Collaborator

Edi61 commented Apr 24, 2023

Hi @heinrichI,
It seems that I have forgotten to implement the loading/storing of the CoreOptions, but it's not handled by Corelib.
Same problem should there for all core options, not only CoreCompareOptions.

In AntiDupl.NET.Winforms the storing and loading is handled by the "Load" and "Save" methods from CoreOptions.
Why not handle it the same way when opening and closing the MainViewModel?
see also

m_coreOptions = CoreOptions.Load(m_options.coreOptionsFileName, m_core, m_options.onePath);

m_coreOptions.Save(m_options.coreOptionsFileName);

@kamikaze00007
Copy link

kamikaze00007 commented Apr 26, 2023

Hey, uh, sorry to interject here. But could the configuration being unable to be changed related to the issue why CompareInsideOneFolder and CompareInsideOneSearchPath doesn't work for me even if I have either one turned On or Off? I have my own issue submitted here too, detailing the problem. Basically, no matter which I turn on or turn off, the program is searching duplicates outside of a single folder, even when I want it to just do comparisons of images inside a single folder. It either doesn't find anything at all, or it looks for comparisons outside of the specified folder and into other folders. Here's my report: #173

@Edi61 Edi61 added the bug label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants