Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logging and user interface for CLscraper class #3

Open
eshanprashar opened this issue Sep 18, 2024 · 1 comment
Open

Improve logging and user interface for CLscraper class #3

eshanprashar opened this issue Sep 18, 2024 · 1 comment
Assignees
@eshanprashar
Labels
enhancement New feature or request

Comments

@eshanprashar
Copy link
Owner

eshanprashar commented Sep 18, 2024 •
edited
Loading

Currently, CLscraper fetches data from an API endpoint, but user does not have any visibility on what happens behind the scenes

  • request_count: user should know how many requests are being made
  • progress update: user does not have visibility on how much time it would take to fetch chunk n of data in time t
  • logging: there are no logs user can check in case something goes wrong with scraping
  • storage: user should be able to view data in csvs while the code is running (especially useful for bigger requests)
@eshanprashar eshanprashar added the enhancement New feature or request label Sep 18, 2024
@eshanprashar eshanprashar self-assigned this Sep 18, 2024
eshanprashar added a commit that referenced this issue Sep 19, 2024
@eshanprashar
added func for #3; clscraper class works
3a1c596
@eshanprashar
Copy link
Owner Author

eshanprashar commented Sep 19, 2024 •
edited
Loading

  • request_count: added simple print statement
  • logging: added methods for logging - log files store last url and last page to resume scraping from a specific point
  • storage: added a method to create storage folder for given endpoint and save csvs there
    [ ] progress update: cannot comment on how much time it would take - deprioritized download progress bar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eshanprashar eshanprashar

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eshanprashar