Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard limit of 5s to wait for a channel? #71

Open
brettrp opened this issue Mar 10, 2021 · 1 comment
Open

Hard limit of 5s to wait for a channel? #71

brettrp opened this issue Mar 10, 2021 · 1 comment

Comments

@brettrp
Copy link

brettrp commented Mar 10, 2021

During some load testing for our application, I ran into crashes like the following when calling ExRabbitPool.with_channel:

{:timeout, {GenServer, :call, [#PID<0.2333.0>, :checkout_channel, 5000]}}" (elixir 1.11.2) lib/gen_server.ex:1027: GenServer.call/3

This is because the default timeout for the synchronous GenServer.call/3 for :checkout_channel is 5000ms.

I'm not sure whether this is intended behaviour, or whether the timeout for getting a channel should be configurable, or possibly whether that call should be asynchronous along with a configurable timeout.

@sescobb27
Copy link
Contributor

getting a channel can be configurable, that would be a great PR, maybe passing a keyword options to set the timeout so it can be modified in each case independently with 5sec default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants